Fix: list/search channel properly using cursor #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
commented
Feb 21, 2025
| } catch (e) { | ||
| console.log('Failed to create dataset:', e) | ||
| } | ||
| let allChannels = [] |
There was a problem hiding this comment.
@njhale a lot of formatting changes, but this is the change that i made so that it will follow the cursor and list the rest of the channels. I feel like it is being paginated on their api so we have to go through all the pages.
njhale
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the channel list by using cursor to find the rest of the results, also use formatter to format code properly.
obot-platform/obot#1827