Enhance: Add support to pull slack bot token #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
commented
Feb 19, 2025
| @@ -12,7 +12,7 @@ Tools: ../../oauth2 | |||
| "oauthInfo": { | |||
| "integration": "slack", | |||
| "token": "SLACK_TOKEN", | |||
| "scope": [ | |||
| "userScope": [ | |||
There was a problem hiding this comment.
I am changing this so that it is consistent with slack.
StrongMonkey
requested review from
thedadams,
njhale,
iwilltry42 and
g-linville
g-linville
approved these changes
Feb 19, 2025
Yeah, I was thinking about pulling it as a separate bundle/tool too, wasn't super comfortable right now to have a separate slack tool to do thing as bot. But yeah we could have the discussion. |
thedadams
approved these changes
Feb 20, 2025
|
@g-linville I am merging this as a tool in existing bundle for now. Will consider adding message to channel later, this is more completing the demo use-case for unsubscribe agent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to use slack bot token to send message a bot. This is done by adding a new tool into slack bundle that consumes a separate credential that requests bot token.