fix: allow no object type for model list #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generic OpenAI compatible model provider requires that the models list returned have an Object parameter with value "list." This parameter is not included in some otherwise compatible model providers and it seems reasonable to not require this field. Signed-off-by: Donnie Adams <[email protected]>
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42 and
g-linville
iwilltry42
approved these changes
Feb 15, 2025
g-linville
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic OpenAI compatible model provider requires that the models list returned have an Object parameter with value "list." This parameter is not included in some otherwise compatible model providers and it seems reasonable to not require this field.
For whatever it's worth: I consider this work to have been done in my free time.