fix: always return database table columns #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there are no rows in a table, the `list_database_table_rows` tool doesn't return table column names. To fix this, use an explicit query to fetch the table columns instead of relying on sqlite3's `-header` option. Addresses obot-platform/obot#1702 Signed-off-by: Nick Hale <[email protected]>
njhale
requested review from
ibuildthecloud,
drpebcak,
thedadams,
ivyjeong13,
tybalex,
StrongMonkey,
iwilltry42,
ryanhopperlowe and
g-linville
g-linville
approved these changes
Feb 10, 2025
StrongMonkey
approved these changes
Feb 10, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are no rows in a table, the
list_database_table_rowstool doesn't return table column names.To fix this, use an explicit query to fetch the table columns instead of relying on sqlite3's
-headeroption.Addresses obot-platform/obot#1702