enhance: add file source and location metadata to knowledge results #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
requested review from
ibuildthecloud,
thedadams,
njhale,
StrongMonkey and
g-linville
thedadams
approved these changes
Feb 11, 2025
g-linville
approved these changes
Feb 11, 2025
result-formatter/main.go
Outdated
| } | ||
| if location != "" && doc.Metadata.TotalPages > 0 { | ||
| location = fmt.Sprintf("%s of %d", location, doc.Metadata.TotalPages) | ||
| _, _ = fmt.Fprintf(os.Stderr, "result doc in file %q at %q\n", filename, location) |
There was a problem hiding this comment.
was this done only for debugging or should it be left in?
There was a problem hiding this comment.
It's debug logs here and below. I just left them in as they shouldn't do any harm going to stderr.
I can remove them if needed though (I hope I won't need them anymore 😬 )
result-formatter/main.go
Outdated
| } else { | ||
| url = doc.Metadata.URL | ||
| } | ||
| _, _ = fmt.Fprintf(os.Stderr, "result doc url %q\n", url) |
|
Waiting for @ibuildthecloud 's feedback as per https://acorn-io.slack.com/archives/C03FU91U4SX/p1739250347442839?thread_ts=1738968457.770299&cid=C03FU91U4SX |
This was referenced Feb 14, 2025
iwilltry42
force-pushed
the
feat/result-formatter-file-source
branch
2 times, most recently
from
9842661 to
4e92c33
Compare
iwilltry42
force-pushed
the
feat/result-formatter-file-source
branch
from
4e92c33 to
db356ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack thread: https://acorn-io.slack.com/archives/C03FU91U4SX/p1738968457770299
Issue obot-platform/obot#1692