-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: General File Reader Tool #398
base: main
Are you sure you want to change the base?
Conversation
Hm. This isn't really a file reader tool. It's a "Convert to markdown" tool. I'm not sure that's what we want. I had envisioned a tool that reads a file and sends the contents directly to the LLM. Do you not think that approach will work well? What happens if the user just says "Read the court filings file" or "What's the highest grossing office in my spreadsheet?" Will this tool be called? I'm also not sure that we want to create double the artifacts in the workspace. |
Technically this tool parses the text content from pdf/pptx/docx documents, so it is a
We can support both, and make it sends content back to llm by default. In the case of when the file has too much text, then it should probably write to a file and use a summarizer tool to handle the text.
For structured data like a spreadsheet(I mean excel/csv/json .. etc), we will need to handle it separately. |
@cjellick I made an update, now this tool will send the content directly to LLM by default. If user specifies an output file, then it will do so. |
Co-authored-by: Craig Jellick <[email protected]>
@tybalex what happens if the amount of text exceeds the context window? Is it something we handle gracefully? |
that's a really good question. It is a problem when it directly returns back to the LLM, I will need to think about it. |
This PR adds a general
File-Reader Tool
by reusing existing knowledge ingestion code.This tool can parse the content of input workspace file(word, pdfs, slides) and convert to markdown format and print to stdout by default or write to a workspace file.
This tool also helps address issues like obot-platform/obot#1405, by:
@cjellick @thedadams I wonder if gptscript could support a syntax such that
File Reader Tool
is always a prerequisite ofSummarizer Tool
.