change: move claude3-provider-common code to anthropic-model-provider #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwilltry42
requested review from
thedadams,
njhale,
sanjay920,
StrongMonkey and
g-linville
iwilltry42
force-pushed
the
change/anthropic-shared
branch
from
1202622 to
35c71d1
Compare
g-linville
approved these changes
Jan 17, 2025
iwilltry42
force-pushed
the
change/anthropic-shared
branch
from
9bf203a to
f893bd9
Compare
|
Rebased and opened the related PR on the enterprise-tools repo: https://github.com/obot-platform/enterprise-tools/pull/2 |
thedadams
approved these changes
Jan 20, 2025
Comment on lines
+53
to
+56
| return StreamingResponse( | ||
| "data: " + mapped_response.model_dump_json() + "\n\n", | ||
| media_type="application/x-ndjson", | ||
| ) |
There was a problem hiding this comment.
Does this mean that these don't do streaming?
There was a problem hiding this comment.
I have a Follow-Up PR to switch between streaming and non-streaming in the works.
This is mostly a copy-paste of the old module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this we can get rid of https://github.com/gptscript-ai/claude3-provider-common