enhance: start worker goroutines on demand #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
force-pushed
the
minimize-worker-goroutines
branch
from
8477886 to
84c6a12
Compare
Instead of having a bunch of waiting goroutines, this change will introduce one goroutine per type that waits for new tasks. That goroutine will spin up new goroutines, up to the desired limit, to handle tasks as they come in. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
minimize-worker-goroutines
branch
from
84c6a12 to
1f6217c
Compare
cjellick
approved these changes
Feb 7, 2025
A QueueSplitter interface is added that allows the caller to have multiple worker queues per GVK. This allows for a sort of priority-based queuing mechanism. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
minimize-worker-goroutines
branch
from
764e330 to
9ff66f3
Compare
g-linville
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a bunch of waiting goroutines, this change will introduce one goroutine per type that waits for new tasks. That goroutine will spin up new goroutines, up to the desired limit, to handle tasks as they come in.
Issue: obot-platform/obot#1694