Add/streamline property chains over 'in taxon' (RO:0002162). #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds several property chains of the form X o 'in taxon' SubPropertyOf: 'in taxon' where X represents the following properties: * 'mereotologically related to' (RO:0002323), * 'developmentally related to' (RO:0002324), * 'relation between physical entity and a process or stage' (RO:0002487), * 'innervated_by' (RO:0002005), * 'innvervates' (RO:0002134), * 'produced by' (RO:0003001), * 'produces' (RO:0003000). Existing property chains over properties that are subproperties of those listed above (e.g. 'part of', BFO:0000050) are removed since they are no longer necessary. closes #831
|
Yes, I’ve been wondering about this one as well. I would have no objection to setting the chain one level below, at the level of 'existence overlaps' instead. |
|
@gouttegd explain his reasoning on the RO call, and I agree with him. I don't use these relations in my work, so I can't test them myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several property chains of the form
where X represents the following properties:
Existing property chains over properties that are subproperties of those listed above (e.g. 'part of', BFO:0000050) are removed since they are no longer necessary.
closes #831