-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 2645/feedback request add ability to request feedback from external source #2856
Open
ocielliottc
wants to merge
123
commits into
develop
Choose a base branch
from
feature-2645/feedback-request-add-ability-to-request-feedback-from-external-source
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature 2645/feedback request add ability to request feedback from external source #2856
ocielliottc
wants to merge
123
commits into
develop
from
feature-2645/feedback-request-add-ability-to-request-feedback-from-external-source
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
…ption, but returns null. And, a litle formatting and code cleanup in preparation for making a PR.
…-to-request-feedback-from-external-source
…-to-request-feedback-from-external-source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A big effort from @Luch76 to request and receive feedback from external recipients!
This includes a new table to hold external recipients and the ability to mark feedback templates as external-only.
An initial email is sent to the external recipient upon requesting feedback. The external recipient will receive a second email once they "verify" their email and from there, they can go to the page to complete the feedback request.