Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin toolchain for rustdoc-v26 #311

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

fprasx
Copy link
Contributor

@fprasx fprasx commented Jan 11, 2024

No description provided.

@fprasx
Copy link
Contributor Author

fprasx commented Jan 12, 2024

This log line from rustup indicates that the action is not correctly overriding the toolchain file (this was from attempting to use 1.72:

info: note that the toolchain '1.73-x86_64-unknown-linux-gnu' is currently in use 
(overridden by '.../rust-toolchain.toml')

which indicates that the action is not correctly overriding the toolchain file. rustup override set $TOOLCHAIN seems to work locally. Issue: actions-rust-lang/setup-rust-toolchain#31

Confusingly though, the test cases are still failing. This seems related to ./scripts/regenerate_test_rustdocs.sh being explicitly invoked with +$TOOLCHAIN, while cargo is not. Explicitly invoking cargo with +$TOOLCHAIN fixes things. I'm not sure why the adapter compiled and run under 1.73 would be incompatible with rustdoc generated by 1.72.

It seems like we can wait for the action to merge a fix or merge this PR as is. Once we decide a course of action I'll pin the toolchain for rustdoc-v27.

@obi1kenobi
Copy link
Owner

Let's merge this as-is. Since this is a branch that isn't the latest, I think it's probably not worth spending too much more energy on it.

Thanks for digging into the cause and opening the issue upstream, it looks good to me.

@obi1kenobi obi1kenobi merged commit 3b909b0 into obi1kenobi:rustdoc-v26 Jan 12, 2024
8 checks passed
@fprasx
Copy link
Contributor Author

fprasx commented Jan 12, 2024

Hype. PR for rustdoc-v27 coming up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants