Skip to content

Commit

Permalink
Unset RUSTFLAGS value in semver job
Browse files Browse the repository at this point in the history
Don't fail semver-checking if a dependency version has warnings, such as deprecation notices.

More context:
libp2p#4932 (comment)
obi1kenobi/cargo-semver-checks#589
  • Loading branch information
obi1kenobi authored Nov 28, 2023
1 parent 89fe068 commit 76a985e
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,15 @@ jobs:
semver:
runs-on: ubuntu-latest
env:
# Unset the global `RUSTFLAGS` env to allow warnings.
# cargo-semver-checks intentionally re-locks dependency versions
# before checking, and we shouldn't fail here if a dep has a warning.
#
# More context:
# https://github.com/libp2p/rust-libp2p/pull/4932#issuecomment-1829014527
# https://github.com/obi1kenobi/cargo-semver-checks/issues/589
RUSTFLAGS: ''
steps:
- uses: actions/checkout@v4
- run: wget -q -O- https://github.com/obi1kenobi/cargo-semver-checks/releases/download/v0.25.0/cargo-semver-checks-x86_64-unknown-linux-gnu.tar.gz | tar -xz -C ~/.cargo/bin
Expand Down

0 comments on commit 76a985e

Please sign in to comment.