Added lint enum_tuple_variant_field_now_doc_hidden #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obi1kenobi
reviewed
Mar 8, 2024
| #[doc(hidden)] | ||
| pub enum PulicEnumC{ | ||
| TupleVariantWithPublicField(#[doc(hidden)] u8,i64), | ||
| } |
There was a problem hiding this comment.
Could you please use rustfmt on all Rust files and ensure they end with a trailing newline?
You should be able to configure your editor to do this automatically on save.
| field { | ||
| field_name: name @output @tag | ||
| public_api_eligible @filter(op: "=", value: ["$true"]) | ||
|
|
Open
20 tasks
|
I'm planning to make a new release this weekend, so this lint will be part of it and you'll get a shout-out in the release notes 🚀 Might you be interested in writing the lint for enum struct variants' fields as well? It's very, very similar to this one, and it would be great to ship them both together in the same release. |
|
Sure, I will start working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint for when a field in tuple variant in public enum is now marked as #[doc(hidden)]
Issue mentioned in #578