Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running cargo semver-checks with no other arguments should default to checking #459

Merged
merged 9 commits into from
May 31, 2023
Merged

Running cargo semver-checks with no other arguments should default to checking #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
253e44c
cargo semver-checks with no other arguments should default to checking
era May 30, 2023
5cc5793
Update tests/feature_config.rs
era May 31, 2023
6f0f4d4
addresses comments on PR
era May 31, 2023
1222050
cargo fmt
era May 31, 2023
77705b3
Update src/main.rs
era May 31, 2023
64269ed
address comments from pr
era May 31, 2023
8e8a98c
merge
era May 31, 2023
0978ad4
trailing line between constant and method
era May 31, 2023
f37b961
Merge branch 'main' into era/run_with_no_args
era May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ fn main() -> anyhow::Result<()> {
)?;
}

let mut config = GlobalConfig::new().set_level(args.verbosity.log_level());
let mut config = GlobalConfig::new().set_level(args.check_release.verbosity.log_level());
config.shell_note("Use `--explain <id>` to see more details")?;
std::process::exit(0);
} else if let Some(id) = args.explain.as_deref() {
Expand All @@ -75,19 +75,15 @@ fn main() -> anyhow::Result<()> {
std::process::exit(0);
}

match args.command {
Some(SemverChecksCommands::CheckRelease(args)) => {
let check: cargo_semver_checks::Check = args.into();
let report = check.check_release()?;
if report.success() {
std::process::exit(0)
} else {
std::process::exit(1);
}
}
None => {
anyhow::bail!("subcommand required");
}
let check: cargo_semver_checks::Check = match args.command {
Some(SemverChecksCommands::CheckRelease(args)) => args.into(),
None => args.check_release.into(),
};
let report = check.check_release()?;
if report.success() {
std::process::exit(0);
} else {
std::process::exit(1);
}
}

Expand All @@ -111,8 +107,8 @@ struct SemverChecks {
#[arg(long, global = true, exclusive = true)]
list: bool,

#[command(flatten)]
verbosity: clap_verbosity_flag::Verbosity<clap_verbosity_flag::InfoLevel>,
obi1kenobi marked this conversation as resolved.
Show resolved Hide resolved
#[clap(flatten)]
check_release: CheckRelease,

#[command(subcommand)]
command: Option<SemverChecksCommands>,
Expand Down
Loading