Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded_io_async::ReadReady trait #35

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haijd
Copy link

@haijd haijd commented Feb 2, 2024

Support embedded_io_async::ReadReady trait

@obabec
Copy link
Owner

obabec commented Feb 19, 2024

@haijd HI, thanks for the PR!
I don't see anything wrong with the PR but please implement ReadReady for the tests so we can approve it possibly.

@obabec obabec requested a review from lulf February 19, 2024 11:38
Copy link
Collaborator

@lulf lulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants