Skip to content

Commit

Permalink
build-support: add new hooks (NixOS#370869)
Browse files Browse the repository at this point in the history
  • Loading branch information
drupol authored Jan 30, 2025
2 parents 100e36a + f811073 commit 613933c
Show file tree
Hide file tree
Showing 5 changed files with 75 additions and 0 deletions.
6 changes: 6 additions & 0 deletions doc/redirects.json
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,12 @@
"set-source-date-epoch-to-latest.sh": [
"index.html#set-source-date-epoch-to-latest.sh"
],
"add-bin-to-path.sh": [
"index.html#add-bin-to-path.sh"
],
"writable-tmpdir-as-home.sh": [
"index.html#writable-tmpdir-as-home.sh"
],
"bintools-wrapper": [
"index.html#bintools-wrapper"
],
Expand Down
25 changes: 25 additions & 0 deletions doc/stdenv/stdenv.chapter.md
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,31 @@ This hook only runs when compiling for Linux.

This sets `SOURCE_DATE_EPOCH` to the modification time of the most recent file.

### `add-bin-to-path.sh` {#add-bin-to-path.sh}

This setup hook checks if the `bin/` directory exists in the `$out` output path
and, if so, adds it to the `PATH` environment variable. This ensures that
executables located in `$out/bin` are accessible.

This hook is particularly useful during testing, as it allows packages to locate their executables without requiring manual modifications to the `PATH`.

**Note**: This hook is specifically designed for the `$out/bin` directory only
and does not handle and support other paths like `$sourceRoot/bin`. It may not
work as intended in cases with multiple outputs or when binaries are located in
directories like `sbin/`. These caveats should be considered when using this
hook, as they might introduce unexpected behavior in some specific cases.

### `writable-tmpdir-as-home.sh` {#writable-tmpdir-as-home.sh}

This setup hook ensures that the directory specified by the `HOME` environment
variable is writable. If it is not, the hook assigns `HOME` to a writable
directory (in `.home` in `$NIX_BUILD_TOP`). This adjustment is necessary for
certain packages that require write access to a home directory. This hook can
be added to any phase.

By setting `HOME` to a writable directory, this setup hook prevents failures in
packages that attempt to write to the home directory.

### Bintools Wrapper and hook {#bintools-wrapper}

The Bintools Wrapper wraps the binary utilities for a bunch of miscellaneous purposes. These are GNU Binutils when targeting Linux, and a mix of cctools and GNU binutils for Darwin. \[The “Bintools” name is supposed to be a compromise between “Binutils” and “cctools” not denoting any specific implementation.\] Specifically, the underlying bintools package, and a C standard library (glibc or Darwin’s libSystem, just for the dynamic loader) are all fed in, and dependency finding, hardening (see below), and purity checks for each are handled by the Bintools Wrapper. Packages typically depend on CC Wrapper, which in turn (at run time) depends on the Bintools Wrapper.
Expand Down
15 changes: 15 additions & 0 deletions pkgs/build-support/setup-hooks/add-bin-to-path.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# shellcheck shell=bash
# This setup hook add $out/bin to the PATH environment variable.

export PATH

addBinToPath () {
# shellcheck disable=SC2154
if [ -d "$out/bin" ]; then
PATH="$out/bin:$PATH"
export PATH
fi
}

# shellcheck disable=SC2154
addEnvHooks "$targetOffset" addBinToPath
15 changes: 15 additions & 0 deletions pkgs/build-support/setup-hooks/writable-tmpdir-as-home.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# shellcheck shell=bash
# This setup hook set the HOME environment variable to a writable directory.

export HOME

writableTmpDirAsHome () {
if [ ! -w "$HOME" ]; then
HOME="$NIX_BUILD_TOP/.home"
mkdir -p "$HOME"
export HOME
fi
}

# shellcheck disable=SC2154
addEnvHooks "$targetOffset" writableTmpDirAsHome
14 changes: 14 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,13 @@ with pkgs;

__flattenIncludeHackHook = callPackage ../build-support/setup-hooks/flatten-include-hack { };

addBinToPathHook = callPackage (
{ makeSetupHook }:
makeSetupHook {
name = "add-bin-to-path-hook";
} ../build-support/setup-hooks/add-bin-to-path.sh
) { };

autoreconfHook = callPackage (
{ makeSetupHook, autoconf, automake, gettext, libtool }:
makeSetupHook {
Expand Down Expand Up @@ -853,6 +860,13 @@ with pkgs;
name = "setup-debug-info-dirs-hook";
} ../build-support/setup-hooks/setup-debug-info-dirs.sh;

writableTmpDirAsHomeHook = callPackage (
{ makeSetupHook }:
makeSetupHook {
name = "writable-tmpdir-as-home-hook";
} ../build-support/setup-hooks/writable-tmpdir-as-home.sh
) { };

useOldCXXAbi = makeSetupHook {
name = "use-old-cxx-abi-hook";
} ../build-support/setup-hooks/use-old-cxx-abi.sh;
Expand Down

0 comments on commit 613933c

Please sign in to comment.