No empty identifier allowed.

oat-sa · Apr 28, 2016 · fc1cc18 · fc1cc18
1 parent 4a7e2f1
commit fc1cc18
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/qtism/common/datatypes/QtiIdentifier.php b/src/qtism/common/datatypes/QtiIdentifier.php
@@ -44,6 +44,9 @@ protected function checkType($value)
         if (is_string($value) !== true) {
             $msg = "The Identifier Datatype only accepts to store identifier values.";
             throw new InvalidArgumentException($msg);
+        } elseif ($value === '') {
+            $msg = "The Identifier Datatype do not accept empty strings as valid identifiers.";
+            throw new InvalidArgumentException($msg);
         }
     }
 

diff --git a/test/qtismtest/common/datatypes/IdentifierTest.php b/test/qtismtest/common/datatypes/IdentifierTest.php
@@ -7,7 +7,18 @@
 class IdentifierTest extends QtiSmTestCase {
 
     public function testWrongValue() {
-        $this->setExpectedException('\\InvalidArgumentException');
+        $this->setExpectedException(
+            '\\InvalidArgumentException',
+            'The Identifier Datatype only accepts to store identifier values.'
+        );
         $float = new QtiIdentifier(1337);
     }
-}
+
+    public function testEmptyIdentifier() {
+        $this->setExpectedException(
+            '\\InvalidArgumentException',
+            'The Identifier Datatype do not accept empty strings as valid identifiers.'
+        );
+        $float = new QtiIdentifier('');
+    }
+}