Stronger type juggling in setOutcomeValue rule processor.

oat-sa · Jul 28, 2016 · d8495ac · d8495ac
1 parent 28d4b4d
commit d8495ac
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 3 deletions.
diff --git a/qtism/runtime/rules/SetOutcomeValueProcessor.php b/qtism/runtime/rules/SetOutcomeValueProcessor.php
@@ -116,6 +116,11 @@ public function process() {
 		    if ($val !== null && $var->getCardinality() === Cardinality::SINGLE) {
 		        $baseType = $var->getBaseType();
 
+                // If we are trying to put a container in a scalar, let's make some changes...
+                if (($val->getCardinality() === Cardinality::MULTIPLE || $val->getCardinality() === Cardinality::ORDERED) && count($val) > 0) {
+                    $val = $val[0];
+                }
+
 		        if ($baseType === BaseType::INTEGER && $val instanceof QtiFloat) {
 		            $val = new QtiInteger(intval($val->getValue()));
 		        }

diff --git a/test/qtism/runtime/rules/SetOutcomeValueProcessorTest.php b/test/qtism/runtime/rules/SetOutcomeValueProcessorTest.php
@@ -97,11 +97,12 @@ public function testSetOutcomeValueWrongJugglingMultipleOne() {
 	    $processor->process();
 	}
 
-	public function testSetOutcomeValueWrongJugglingMultipleTwo() {
+	public function testSetOutcomeValueJugglingMultiple() {
 	    $rule = $this->createComponentFromXml('
 	        <setOutcomeValue identifier="SCORE">
 	            <multiple>
 	                <baseValue baseType="float">1337.1337</baseValue>
+                    <baseValue baseType="float">7777.7777</baseValue>
 	            </multiple>
 	        </setOutcomeValue>
 	    ');
@@ -110,10 +111,57 @@ public function testSetOutcomeValueWrongJugglingMultipleTwo() {
 	    $score = new OutcomeVariable('SCORE', Cardinality::SINGLE, BaseType::INTEGER);
 	    $state = new State(array($score));
 	    $processor->setState($state);
-
-	    $this->setExpectedException('qtism\\runtime\\rules\\RuleProcessingException');
 	    $processor->process();
+
+        // In this case, juggling will put the first entry of the multiple container
+        // in the target single cardinality variable. The float value is then changed into an integer value.
+        $processor->process();
+        $this->assertEquals(1337, $state['SCORE']->getValue());
 	}
+
+    public function testSetOutcomeValueJugglingOrdered() {
+        $rule = $this->createComponentFromXml('
+            <setOutcomeValue identifier="SCORE">
+                <ordered>
+                    <baseValue baseType="float">1337.1337</baseValue>
+                    <baseValue baseType="float">7777.7777</baseValue>
+                </ordered>
+            </setOutcomeValue>
+        ');
+
+        $processor = new SetOutcomeValueProcessor($rule);
+        $score = new OutcomeVariable('SCORE', Cardinality::SINGLE, BaseType::INTEGER);
+        $state = new State(array($score));
+        $processor->setState($state);
+
+        // In this case, juggling will put the first entry of the multiple container
+        // in the target single cardinality variable. The float value is then changed into an integer value.
+        $processor->process();
+        $this->assertEquals(1337, $state['SCORE']->getValue());
+	}
+
+    public function testSetOutcomeValueWrongJugglingMultipleBecauseWrongBaseType() {
+        $rule = $this->createComponentFromXml('
+            <setOutcomeValue identifier="SCORE">
+                <multiple>
+                    <baseValue baseType="string">hello</baseValue>
+                    <baseValue baseType="string">world</baseValue>
+                </multiple>
+            </setOutcomeValue>
+        ');
+
+        $processor = new SetOutcomeValueProcessor($rule);
+        $score = new OutcomeVariable('SCORE', Cardinality::SINGLE, BaseType::INTEGER);
+        $state = new State(array($score));
+        $processor->setState($state);
+
+        $this->setExpectedException(
+            'qtism\\runtime\\rules\\RuleProcessingException',
+            'Unable to set value hello to variable \'SCORE\' (cardinality = single, baseType = integer).'
+        );
+
+        $processor->process();
+    }
 
 	public function testSetOutcomeValueModerate() {
 		$rule = $this->createComponentFromXml('