Feature/ADF-1695/Show multiple preview buttons #2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
gabrielfs7
reviewed
Jul 4, 2024
Comment on lines
+77
to
+92
| /** | ||
| * We assume the ClientLibConfigRegistry is filled up with something like this: | ||
| * 'taoQtiTest/controller/creator/creator' => [ | ||
| * 'provider' => 'qtiTest', | ||
| * ], | ||
| * | ||
| * Or, with something like this for allowing multiple buttons in case of several providers are available: | ||
| * 'taoQtiTest/controller/creator/creator' => [ | ||
| * 'provider' => 'qtiTest', | ||
| * 'providers' => [ | ||
| * ['id' => 'qtiTest', 'label' => 'Preview'], | ||
| * ['id' => 'xxxx', 'label' => 'xxxx'], | ||
| * ... | ||
| * ], | ||
| * ], | ||
| */ |
There was a problem hiding this comment.
I've mentioned it in the other PR about items. This should be in a private method getProviders JSDoc describing the contract and helping even IDE autocomplete and documenting the code (since we do not have domain objects for this).
gabrielfs7
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
LGTM. Code review only :)
Thanks @jsconan
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 3 features, 0 fix |
shaveko
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good to me, nice job!
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://oat-sa.atlassian.net/browse/ADF-1695
Requires:
Summary
Add the possibility of having more than one test previewer.
Details
It supports multiple preview buttons from the test's property page.
This is made thanks to a configuration applied in
config/tao/client_lib_config_registry.conf.php, and a change applied to thestructures.xmlfile.Each button must be declared with an identifier starting with
test-preview. The first button must betest-preview, the secondtest-preview-1, etc. The suffix number refers to a position in the configuration (seeclient_lib_config_registry.conf.php).Example:
The configuration can be extended with a list of possible providers, aside from the default one. This is done in
config/tao/client_lib_config_registry.conf.php.Example:
How to test
git checkout -t origin/feature/ADF-1695/multiple-preview-buttons