-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update methods to lodash 4 version #2431
Conversation
Front-end summary Node 18
|
…ash v4 Signed-off-by: Sergei Mikhailov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2431 +/- ##
=============================================
+ Coverage 16.88% 17.02% +0.13%
- Complexity 3222 3228 +6
=============================================
Files 209 209
Lines 11594 11651 +57
=============================================
+ Hits 1958 1983 +25
- Misses 9636 9668 +32 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the failing tests tomorrow, @taopkorczak.
And make sure to merge this PR after fixing the tests.
https://github.com/oat-sa/extension-tao-testqti/actions/runs/7744941999/job/21123704626
If the tests are failing for reasons irrelevant to the changes made here, feel free to merge as-is and fix the tests in a follow-up PR.
Version
There are 0 BREAKING CHANGE, 0 feature, 4 fixes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - fingers crossed...
Related: https://oat-sa.atlassian.net/browse/ADF-1579
Update lodash methods to version 4.