chore: rename props, return null

oat-sa · Aug 7, 2024 · 3d5d769 · 3d5d769
1 parent 8f6a918
commit 3d5d769
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/actions/class.RestQtiTests.php b/actions/class.RestQtiTests.php
@@ -319,20 +319,20 @@ private function getUploadedPackageData()
     }
 
     /**
-     * @return string
+     * @return string|null
      * @throws common_exception_RestApi
      */
-    private function getSubclassLabel(): string
+    private function getSubclassLabel(): ?string
     {
-        $packageLocale = $this->getPostParameter(self::SUBCLASS_LABEL, '');
+        $subclassLabel = $this->getPostParameter(self::SUBCLASS_LABEL);
 
-        if (!is_string($packageLocale)) {
+        if ($subclassLabel !== null && !is_string($subclassLabel)) {
             throw new common_exception_RestApi(
                 sprintf('%s parameter should be string', self::SUBCLASS_LABEL)
             );
         }
 
-        return $packageLocale;
+        return $subclassLabel;
     }
 
     /**
@@ -343,7 +343,7 @@ private function getOverwriteTestUri(): ?string
     {
         $overwriteTestUri = $this->getPostParameter(self::OVERWRITE_TEST_URI);
 
-        if (!is_null($overwriteTestUri) && !is_string($overwriteTestUri)) {
+        if ($overwriteTestUri !== null && !is_string($overwriteTestUri)) {
             throw new common_exception_RestApi(
                 sprintf('%s parameter should be string', self::OVERWRITE_TEST_URI)
             );