feat/AUT-3623/hide-features-in-solar-design #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Front-end summary Node 18
|
This was referenced Jun 10, 2024
| @@ -134,7 +135,7 @@ define([ | |||
| break; | |||
| } | |||
|
|
|||
| if (rp.processingType === 'templateDriven' && !allowCustomTemplate) { | |||
| if ((rp.processingType === 'templateDriven' && !allowCustomTemplate) || !features.isVisible('taoQtiItem/creator/interaction/response/responseProcessing/custom')) { | |||
There was a problem hiding this comment.
we could probably move it ('taoQtiItem/creator/interaction/response/responseProcessing/custom') to the ..Key constant also, for better readability
viktar-dzmitryieu-tao
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master
jsconan
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
It works, at least in my local environment.
In the deployed environment, I got errors when opening the item authoring, it complains about missing libs (pdfjs)
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
Signed-off-by: Saba <[email protected]>
Version
There are 0 BREAKING CHANGE, 8 features, 4 fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
###Description
This PR addresses requirement 3.g from the ticket to hide tenant selector if there is single tenant available from Publish test form page if solar design is activated.
How to test
To test locally the dependent FE/BE branches should be specified in
composer.jsonDeployed to kitchen env, so functionally can be validated there: http://test-rfe-1147-facelift.playground.kitchen.it.taocloud.org:49381/