go/consensus/cometbft/roothash: Publish the last block on subscribe #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes ensure the latest block is correctly replayed, eliminating the need to enforce monotonically increasing blocks.
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6083 +/- ##
==========================================
+ Coverage 64.86% 65.26% +0.40%
==========================================
Files 636 636
Lines 64641 64621 -20
==========================================
+ Hits 41929 42178 +249
+ Misses 17823 17535 -288
- Partials 4889 4908 +19 ☔ View full report in Codecov by Sentry. |
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
deleted the
peternose/trivial/simplify-roothash-watch-blocks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaying the latest block with a hook was not ideal because if the broker still had blocks in the queue while adding a new subscription, it could result in an unexpected block order and potentially cause the last block to be replayed twice.
Solution with monotonically increasing order solved this problem, but there is a simpler one where we use broker's option to publish the last block on subscription.