go/consensus/cometbft: Fail ImmutableState creation if version is missing #6040
+38
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
ptrus
force-pushed
the
ptrus/fix/state-missing-version
branch
7 times, most recently
from
0483506 to
d5ba3b2
Compare
ptrus
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6040 +/- ##
==========================================
+ Coverage 64.69% 65.15% +0.46%
==========================================
Files 635 635
Lines 64624 64634 +10
==========================================
+ Hits 41809 42113 +304
+ Misses 17907 17597 -310
- Partials 4908 4924 +16 ☔ View full report in Codecov by Sentry. |
ptrus
force-pushed
the
ptrus/fix/state-missing-version
branch
6 times, most recently
from
3b052c1 to
0eb80e6
Compare
ptrus
commented
Feb 8, 2025
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
peternose
as code owners
kostko
reviewed
Feb 10, 2025
ptrus
force-pushed
the
ptrus/fix/state-missing-version
branch
2 times, most recently
from
0e95d83 to
bec3784
Compare
kostko
approved these changes
Feb 10, 2025
ptrus
force-pushed
the
ptrus/fix/state-missing-version
branch
from
bec3784 to
6eaafdb
Compare
ptrus
force-pushed
the
ptrus/fix/state-missing-version
branch
from
6eaafdb to
14f4641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6039