Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: Refactor and cleanup code #5943

Merged
merged 22 commits into from
Nov 25, 2024
Merged

go: Refactor and cleanup code #5943

merged 22 commits into from
Nov 25, 2024

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Nov 22, 2024 •
edited
Loading

Laying grounds for the main part of the hot-reloading issue and adding minor changes to the code that were found along the way.

@netlify Netlify
Copy link

netlify bot commented Nov 22, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name Link
🔨 Latest commit 7a86da6
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/6744833c318afc000857c9e4

@peternose peternose marked this pull request as ready for review November 22, 2024 13:00
@peternose peternose linked an issue Nov 22, 2024 that may be closed by this pull request
Hot-loading and distribution system for runtime bundles #5755
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.59509% with 30 lines in your changes missing coverage. Please review.

Project coverage is 65.20%. Comparing base (ea97401) to head (7a86da6).
Report is 30 commits behind head on master.

Files with missing lines Patch % Lines
go/runtime/bundle/bundle.go 20.00% 8 Missing ⚠️
go/runtime/registry/registry.go 76.66% 5 Missing and 2 partials ⚠️
go/runtime/registry/config.go 82.75% 1 Missing and 4 partials ⚠️
go/worker/common/worker.go 62.50% 2 Missing and 1 partial ⚠️
go/oasis-node/cmd/storage/storage.go 0.00% 2 Missing ⚠️
go/runtime/history/prune.go 93.10% 2 Missing ⚠️
go/runtime/host/composite/composite.go 60.00% 1 Missing and 1 partial ⚠️
go/runtime/history/history.go 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5943      +/-   ##
==========================================
+ Coverage   64.87%   65.20%   +0.32%     
==========================================
  Files         627      629       +2     
  Lines       64306    64297       -9     
==========================================
+ Hits        41719    41924     +205     
+ Misses      17728    17441     -287     
- Partials     4859     4932      +73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

kostko
kostko approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe rename commit:

-go/runtime/registry: Create history factor helper function
+go/runtime/registry: Create history factory helper function

@peternose
go/runtime/config: Use map instead of interface for local config
7b1ff5f 
This simplifies the code, as we only use maps for local configuration.
If a more generalized configuration is needed, we can revert to using
an interface.
@peternose
go/oasis-node/cmd/node: Rename registration to workerRegistration
a502684
@peternose
go/worker/common/worker: Merge worker constructors
952958a
@peternose
go/runtime/host/composite: Simplify interation over components
a0b564a
@peternose
go/runtime/registry/config: Remove runtime host config
76f4607
@peternose
go/runtime/registry/config: Rename runtime config constructor
d8730b2
@peternose
go/runtime/registry/config: Use max function to compute min interval
0a6cc9d
@peternose
go/registry/api/runtime: Improve comment for bundle checksum
38edded
@peternose
go/runtime/history: Create pruner constructors and fix loggers
ef88ff3
@peternose
go/runtime/history/prune: Move prune interval to pruner
61fa078
@peternose
go/runtime/history/prune: Remove base pruner
6f0488c
@peternose
go/runtime/history/prune: Lock prune handlers in update function
d756bdd
@peternose
go/runtime/history: Add history factory
20c5b5a
@peternose
go/runtime/registry: Create history factory helper function
330d6d8
@peternose
go/runtime/registry: Change function newRuntime to method
54a1550
@peternose
go/runtime/bundle: Return location when exploding bundle
26f63d9
@peternose
go/runtime/registry: Remove unused code
dd41997
@peternose
go/common/badger: Add Start method to GC worker
f30b47e
@peternose
runtime/bundle: Fix grammar in function name
d8a981e
@peternose
go/p2p/peermgmt/registry: Move state reset to a new function
44a5d48
@peternose
go/runtime/registry: Remove unused roles
52aebc0
@peternose peternose force-pushed the peternose/trivial/refactor-cleanup branch from 4e1752d to 52aebc0 Compare November 25, 2024 12:17
@peternose peternose merged commit d35e24b into master Nov 25, 2024
7 checks passed
@peternose peternose deleted the peternose/trivial/refactor-cleanup branch November 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hot-loading and distribution system for runtime bundles
2 participants
@peternose @kostko