go/keymanager/churp: Allow nodes to confirm handoff completion #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the checksum of the last verification matrix to the churp status and reorders some fields. The checksum is needed so that the new nodes can verify switch points in handoffs.
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
✅ Deploy Preview for oasisprotocol-oasis-core canceled.
|
peternose
force-pushed
the
peternose/feature/churp-confirm
branch
from
46bc9d8 to
3f71e2a
Compare
peternose
force-pushed
the
peternose/feature/churp-confirm
branch
from
3f71e2a to
9cd8840
Compare
kostko
reviewed
Apr 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5628 +/- ##
==========================================
- Coverage 65.34% 65.29% -0.05%
==========================================
Files 593 593
Lines 60844 60952 +108
==========================================
+ Hits 39758 39799 +41
- Misses 16404 16463 +59
- Partials 4682 4690 +8 ☔ View full report in Codecov by Sentry. |
The secret polynomial and its verification matrix have been moved to a secret share for easier storage of the player's state.
This change allows us to verify the received verification matrices before decoding.
peternose
force-pushed
the
peternose/feature/churp-confirm
branch
from
9cd8840 to
1706d0d
Compare
Finalize handoffs at the end of an epoch if a threshold number of applicants (plus a few extra) have confirmed the secret share reconstruction.
peternose
force-pushed
the
peternose/feature/churp-confirm
branch
from
1706d0d to
7d649f9
Compare
kostko
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.