Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROLIE category and service document location #745

Merged
merged 3 commits into from
Jun 11, 2024
Merged

ROLIE category and service document location #745

merged 3 commits into from
Jun 11, 2024

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51
ROLIE category document
e581ddd 
- addresses parts of oasis-tcs#632
- provide guidance where to expect a ROLIE category document
@tschmidtb51
ROLIE service document
b416d6d 
- addresses parts of oasis-tcs#632
- provide guidance where to expect a ROLIE service document
- state suggested filename
@tschmidtb51 tschmidtb51 added the csaf 2.1 csaf 2.1 work label May 27, 2024
@tschmidtb51 tschmidtb51 self-assigned this May 27, 2024
@tschmidtb51 tschmidtb51 requested a review from sthagen May 27, 2024 22:23
sthagen
sthagen approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (only one question).

@tschmidtb51
ROLIE service document
9de0c75 
- addresses review comment from oasis-tcs#745
- replace MAY with different wording to show it is optional
@tschmidtb51 tschmidtb51 requested a review from sthagen May 28, 2024 08:08
sthagen
sthagen approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tschmidtb51 tschmidtb51 marked this pull request as ready for review May 29, 2024 20:26
@tschmidtb51 tschmidtb51 added the motion This item has a motion pending label May 29, 2024
@santosomar
Copy link
Contributor

The motion to accept the pull request as suggested in #745 and include it into CSAF 2.1, has passed. It automatically carried on 2024-06-05 23:00 UTC.
https://groups.oasis-open.org/discussion/motion-for-745

@santosomar santosomar merged commit a4f547e into oasis-tcs:editor-revision-2024-05-29 Jun 11, 2024
5 checks passed
@tschmidtb51 tschmidtb51 added motion_passed A motion has passed and removed motion This item has a motion pending motion_passed A motion has passed labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

@santosomar santosomar santosomar approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tschmidtb51 @santosomar @sthagen