Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP User-Agents #742

Merged
merged 3 commits into from
Jun 17, 2024
Merged

HTTP User-Agents #742

merged 3 commits into from
Jun 17, 2024

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51
HTTP User-Agents
a552272 
- addresses parts of oasis-tcs#635
- add new requirement explicitly stating that no blocking is allowed
@tschmidtb51 tschmidtb51 added the csaf 2.1 csaf 2.1 work label May 27, 2024
@tschmidtb51 tschmidtb51 requested a review from sthagen May 27, 2024 09:54
@tschmidtb51 tschmidtb51 self-assigned this May 27, 2024
@tschmidtb51
HTTP User-Agents
df33caa 
- addresses parts of review comments from oasis-tcs#742
- change wording from MUST NOT to MUST (hopefully with same clarity)
- rephrase "white-listing" to exempt
- use new line per sentence
@tschmidtb51 tschmidtb51 requested a review from sthagen May 27, 2024 14:13
sthagen
sthagen approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - when considering the MUST to SHOULD including the simplifications (or similarly).
Maybe we should ask the native English speakers for support, as also the version I came up with to me reads still between clumsy, lamenting, and wishful thinking 😁

@tschmidtb51 tschmidtb51 requested a review from santosomar May 27, 2024 21:12
@tschmidtb51 @sthagen
HTTP User-Agents
65dea4f 
- addresses parts of review comments from oasis-tcs#742
- change wording to SHOULD instead of weak MUST statements

Co-authored-by: Stefan Hagen <[email protected]>
@tschmidtb51 tschmidtb51 marked this pull request as ready for review May 29, 2024 20:39
@tschmidtb51 tschmidtb51 added motion This item has a motion pending and removed tc-discussion-needed labels May 29, 2024
sthagen
sthagen approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tschmidtb51
Copy link
Contributor Author

The motion to accept the pull request as suggested in #742 and include it into CSAF 2.1, has passed. It automatically carried on 2024-06-05 23:00 UTC.

@tschmidtb51 tschmidtb51 removed the motion This item has a motion pending label Jun 17, 2024
@tschmidtb51 tschmidtb51 merged commit f86388e into oasis-tcs:editor-revision-2024-05-29 Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprpic mprpic mprpic left review comments

@sthagen sthagen sthagen approved these changes

@santosomar santosomar santosomar approved these changes

Assignees

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tschmidtb51 @sthagen @mprpic @santosomar