[RHELC-1615, RHELC-1602] Add integration test coverage for EL9 systems #946

danmyway · 2023-09-27T12:11:32Z

include EL9 source systems in the integration test coverage

Jira Issues:

Checklist

PR has been tested manually in a VM (either author or reviewer)
Jira issue has been made public if possible
[RHELC-] is part of the PR title
GitHub label has been added to help with Release notes
PR title explains the change from the user's point of view
Code and tests are documented properly
The commits are squashed to as few commits as possible (without losing data)
When merged: Jira issue has been updated to Release Pending if relevant

packit-as-a-service · 2023-09-27T12:11:41Z

Failed to load packit config file:

Cannot parse package config. ValidationError({'jobs': {11: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}, 12: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}, 17: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}, 20: {'packages': defaultdict(<class 'dict'>, {'convert2rhel': {'value': {'targets': ["Expected 'list[str]' or 'dict[str,dict]', got {'epel-7-x86_64': {'distros': ['centos-7']}, 'epel-8-x86_64': {'distros': ['centos-8-latest']}, 'epel-9-x86_64': None} (type <class 'dict'>)."]}}})}}})

For more info, please check out the documentation or contact the Packit team.

danmyway · 2023-09-27T12:24:01Z

/packit test --labels el9

codecov · 2023-09-27T16:00:02Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.39%. Comparing base (bd4e38a) to head (fc2adf1).
Report is 4 commits behind head on main.

Files	Patch %	Lines
...el/actions/conversion/preserve_only_rhel_kernel.py	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   96.43%   96.39%   -0.04%     
==========================================
  Files          66       66              
  Lines        4996     4998       +2     
  Branches      876      877       +1     
==========================================
  Hits         4818     4818              
- Misses        101      102       +1     
- Partials       77       78       +1

Flag	Coverage Δ
centos-linux-7	`91.82% <0.00%> (-0.04%)`	⬇️
centos-linux-8	`92.71% <0.00%> (-0.04%)`	⬇️
centos-linux-9	`92.75% <0.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

has-bot · 2023-10-09T08:46:15Z

/packit test --labels sanity

@oamg/conversions-qe please review results and provide ack.

Log | Bot Usage

danmyway · 2023-10-09T10:43:12Z

/packit test --labels sanity

* address comments * remove the el9 tests definition in .packit.yaml, which won't work anyway, polute the checks overview * the test definition will be handeled separately in oamg#946 Signed-off-by: Daniel Diblik <[email protected]>

danmyway · 2023-10-16T15:40:58Z

/packit test --labels sanity, el9

danmyway · 2024-04-23T12:10:35Z

/packit test --labels el9

danmyway · 2024-06-10T07:07:52Z

/packit test --labels el9

danmyway · 2024-06-11T13:07:49Z

/packit test --labels el9

tests/integration/tier1/destructive/system-not-up-to-date/test_system_not_up_to_date.py

danmyway · 2024-06-12T17:32:06Z

/packit test --labels el9

danmyway · 2024-08-21T18:11:19Z

/packit test

* modify the main.fmf in plans * point packit to the EL9 targets Signed-off-by: Daniel Diblik <[email protected]>

* simplify the playbooks hardcoding eus versions * include el9 systems in some of the playbooks * include almalinux-repos package in almalinux-9-x86_64.cfg to handle the package * fix OL9 not booting to different kernel by calling grub2-set-default Signed-off-by: Daniel Diblik <[email protected]>

* include the EL9 in more tests * remove the install-submgr ansible role as it was not used anymore anywhere * don't use yum_conf_exclude to exclude the rhn-client-tools packages, use a no obsolete flag in yum calls installing sub-man * fix booting to RHCK on OL9 for real this time * add workaround to the satellite registration fixture to enable the repositories * fix the language test Signed-off-by: Daniel Diblik <[email protected]>

* Add a new post-coversion check verifying default grub entry and correct running kernel * fix broken test, where /etc/yum.repos.d got removed * remove python3-syspurpose outdated remediation to validate RHELC-1389 is resolved Signed-off-by: Daniel Diblik <[email protected]>

* move rocky logos out of packages to swap to excluded packages in rocky 9 config * adjust wrong package in repofile_pkgs in oracle-9-x86_64.cfg Signed-off-by: Daniel Diblik <[email protected]>

* rework test_custom_kernel * add a workaround to set GRUB_ENABLE_BLSCFG to true Signed-off-by: Daniel Diblik <[email protected]>

* the enablement of the BLSCFG needs to be done in specific places to be able to boot to a different kernel Signed-off-by: Daniel Diblik <[email protected]>

* move the standard kernel setup inside the test preparation for oracle * fix bad conditions in the single yum transaction tests Signed-off-by: Daniel Diblik <[email protected]>

* simplify the fixture, set an older kernel as default if present, downgrade otherwise * if we're unable to even downgrade the kernel, try to install an older version from an older repo * fix kernel installation on Oracle in the isolated system test Signed-off-by: Daniel Diblik <[email protected]>

* fix custom kernel installation, by looking for an available kernel version first * fix the grub title string assertion * add rpmdevtools to a list of required packages * fix the workaround_remove_uek fixture to work with python3.6 * use rpmdev-sort to sort installed kernel versions * clean up metadata, remove adjust where unneccessary Signed-off-by: Daniel Diblik <[email protected]>

Signed-off-by: Daniel Diblik <[email protected]>

tests/integration/tier1/destructive/kernel-boot-files/test_handle_corrupted_files.py

tests/integration/tier1/destructive/kernel-boot-files/test_handle_missing_boot_files.py

danmyway · 2024-08-22T15:34:37Z

/packit test

Signed-off-by: Daniel Diblik <[email protected]>

danmyway · 2024-08-22T18:37:32Z

/packit test

danmyway · 2024-08-26T12:17:43Z

Test failure unrelated.

kokesak

Great changes. Merging this biggie

hosekadam · 2024-08-26T13:28:46Z

convert2rhel/data/9/x86_64/configs/rocky-9-x86_64.cfg

@@ -10,10 +10,10 @@ gpg_fingerprints = 702d426d350d275d
 excluded_pkgs =
  rocky-obsolete-packages
  rocky-gpg-keys
+  rocky-logos


The swap doesn't work or this is a mistake?

It doesn't work due to some conflicting files 🥲

hosekadam

Looks good

danmyway force-pushed the tests/el9-conversions branch from 85d2435 to 944f1bc Compare September 27, 2023 12:17

danmyway added the kind/tests Improvement or enhancement of the tests label Sep 27, 2023

danmyway changed the base branch from el9-conversions to main September 27, 2023 13:05

danmyway force-pushed the tests/el9-conversions branch from 944f1bc to 93c8af3 Compare September 27, 2023 15:57

danmyway force-pushed the tests/el9-conversions branch from 93c8af3 to 3810c7b Compare October 9, 2023 08:41

danmyway added the tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. label Oct 9, 2023

danmyway force-pushed the tests/el9-conversions branch from 3810c7b to 178e464 Compare October 16, 2023 15:25

danmyway force-pushed the tests/el9-conversions branch from 178e464 to 28f2d58 Compare April 23, 2024 12:00

danmyway force-pushed the tests/el9-conversions branch 3 times, most recently from e69dc25 to 98e9c77 Compare April 24, 2024 08:28

danmyway force-pushed the tests/el9-conversions branch from 98e9c77 to 796411b Compare June 10, 2024 06:57

danmyway force-pushed the tests/el9-conversions branch 3 times, most recently from 649e2bb to f9f5576 Compare June 11, 2024 12:52

danmyway force-pushed the tests/el9-conversions branch from b86e3b2 to db927cf Compare June 12, 2024 17:07

github-advanced-security bot found potential problems Jun 12, 2024

View reviewed changes

tests/integration/tier1/destructive/system-not-up-to-date/test_system_not_up_to_date.py Fixed Show fixed Hide fixed

danmyway force-pushed the tests/el9-conversions branch from db927cf to ee7c7db Compare June 12, 2024 17:16

danmyway force-pushed the tests/el9-conversions branch from ee7c7db to 779aab6 Compare June 12, 2024 23:06

danmyway mentioned this pull request Aug 21, 2024

[RHELC-1672, RHELC-1707, RHELC-1708] Detect a newer version of RHEL kernel in the main transaction #1323

Merged

8 tasks

danmyway force-pushed the tests/el9-conversions branch from 6e10d14 to 2521071 Compare August 21, 2024 16:59

danmyway added 11 commits August 22, 2024 12:08

Prepare for test coverage

4782c4d

* modify the main.fmf in plans * point packit to the EL9 targets Signed-off-by: Daniel Diblik <[email protected]>

Fix more tests, move rocky-logos to excluded

043cfec

* move rocky logos out of packages to swap to excluded packages in rocky 9 config * adjust wrong package in repofile_pkgs in oracle-9-x86_64.cfg Signed-off-by: Daniel Diblik <[email protected]>

Update kernel fixture in conftest

7e31a96

* rework test_custom_kernel * add a workaround to set GRUB_ENABLE_BLSCFG to true Signed-off-by: Daniel Diblik <[email protected]>

Call the grub_setup_workaround in specific places

67b485c

* the enablement of the BLSCFG needs to be done in specific places to be able to boot to a different kernel Signed-off-by: Daniel Diblik <[email protected]>

Fix single yum transaction and isolated system tests

d1fb4c6

* move the standard kernel setup inside the test preparation for oracle * fix bad conditions in the single yum transaction tests Signed-off-by: Daniel Diblik <[email protected]>

Address review comments

ac6a890

Signed-off-by: Daniel Diblik <[email protected]>

danmyway force-pushed the tests/el9-conversions branch from 2521071 to c146877 Compare August 22, 2024 13:28

github-advanced-security bot found potential problems Aug 22, 2024

View reviewed changes

tests/integration/tier1/destructive/kernel-boot-files/test_handle_corrupted_files.py Fixed Show fixed Hide fixed

tests/integration/tier1/destructive/kernel-boot-files/test_handle_missing_boot_files.py Fixed Show fixed Hide fixed

danmyway force-pushed the tests/el9-conversions branch from c146877 to 3e22673 Compare August 22, 2024 14:35

address reviews

fc2adf1

Signed-off-by: Daniel Diblik <[email protected]>

danmyway force-pushed the tests/el9-conversions branch from 3e22673 to fc2adf1 Compare August 22, 2024 17:33

danmyway changed the title ~~tests/Prepare for el9 test coverage~~ [RHELC-1615] Add integration test coverage for EL9 systems Aug 26, 2024

kokesak approved these changes Aug 26, 2024

View reviewed changes

hosekadam reviewed Aug 26, 2024

View reviewed changes

hosekadam approved these changes Aug 26, 2024

View reviewed changes

kokesak merged commit 9ee4fe3 into oamg:main Aug 26, 2024
69 of 72 checks passed

danmyway deleted the tests/el9-conversions branch September 3, 2024 08:25

pr-watson changed the title ~~[RHELC-1615] Add integration test coverage for EL9 systems~~ [RHELC-1615, RHELC-1602] Add integration test coverage for EL9 systems Sep 5, 2024

bocekm mentioned this pull request Nov 28, 2024

Bump version to 2.2.0 #1441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RHELC-1615, RHELC-1602] Add integration test coverage for EL9 systems #946

[RHELC-1615, RHELC-1602] Add integration test coverage for EL9 systems #946

danmyway commented Sep 27, 2023 •

edited by pr-watson

Loading

packit-as-a-service bot commented Sep 27, 2023

danmyway commented Sep 27, 2023

codecov bot commented Sep 27, 2023 •

edited

Loading

has-bot commented Oct 9, 2023

danmyway commented Oct 9, 2023

danmyway commented Oct 16, 2023

danmyway commented Apr 23, 2024

danmyway commented Jun 10, 2024

danmyway commented Jun 11, 2024

danmyway commented Jun 12, 2024

danmyway commented Aug 21, 2024

danmyway commented Aug 22, 2024

danmyway commented Aug 22, 2024

danmyway commented Aug 26, 2024

kokesak left a comment •

edited

Loading

hosekadam Aug 26, 2024

danmyway Aug 26, 2024

hosekadam left a comment

[RHELC-1615, RHELC-1602] Add integration test coverage for EL9 systems #946

[RHELC-1615, RHELC-1602] Add integration test coverage for EL9 systems #946

Conversation

danmyway commented Sep 27, 2023 • edited by pr-watson Loading

packit-as-a-service bot commented Sep 27, 2023

danmyway commented Sep 27, 2023

codecov bot commented Sep 27, 2023 • edited Loading

Codecov Report

has-bot commented Oct 9, 2023

danmyway commented Oct 9, 2023

danmyway commented Oct 16, 2023

danmyway commented Apr 23, 2024

danmyway commented Jun 10, 2024

danmyway commented Jun 11, 2024

danmyway commented Jun 12, 2024

danmyway commented Aug 21, 2024

danmyway commented Aug 22, 2024

danmyway commented Aug 22, 2024

danmyway commented Aug 26, 2024

kokesak left a comment • edited Loading

Choose a reason for hiding this comment

hosekadam Aug 26, 2024

Choose a reason for hiding this comment

danmyway Aug 26, 2024

Choose a reason for hiding this comment

hosekadam left a comment

Choose a reason for hiding this comment

danmyway commented Sep 27, 2023 •

edited by pr-watson

Loading

codecov bot commented Sep 27, 2023 •

edited

Loading

kokesak left a comment •

edited

Loading