-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1780] Fix bad grub2-mkconfig call on UEFI EL9+ #1444
Conversation
The output of the `grub2-mkconfig` call suggests to not use /boot/efi/EFI/redhat/grub.cfg as an output file, but use the /boot/grub2/grub.cfg instead. Check what major version of OS is running and assign the grub config variable based on that. Additionally make the grub config into a variable inside the remediation - do not always advise to use /boot/efi/EFI/redhat/grub.cfg Reformat the action message. Signed-off-by: Daniel Diblik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
=======================================
Coverage 96.12% 96.12%
=======================================
Files 72 72
Lines 5186 5186
Branches 896 896
=======================================
Hits 4985 4985
Misses 119 119
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For reviewers:
|
The plan which triggered the issue is scheduled here: https://artifacts.osci.redhat.com/testing-farm/e931c267-6758-43a4-bb4b-a888885b51e0 |
EL9 plan is PASSing |
The output of the
grub2-mkconfig
call suggests to not use/boot/efi/EFI/redhat/grub.cfg
as an output file, but use the/boot/grub2/grub.cfg
instead.Check what major version of OS is running and assign the grub config variable based on that.
Additionally, make the grub config into a variable inside the remediation - do not always advise to use the
/boot/efi/EFI/redhat/grub.cfg
Reformat the action message.
Jira Issues:
Checklist
[RHELC-]
or[HMS-]
is part of the PR titleRelease Pending
if relevant