Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1728] Don't update RHSM facts with sub-man not present #1435

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

bocekm
Copy link
Member

@bocekm bocekm commented Nov 22, 2024

When an exception gets raised early before have a chance to install sub-man (for instance when any of the packages installed on the systems are not of the latest version available), convert2rhel hard stops with a traceback when trying to call sub-man which hasn't been installed.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • Label depicting the kind of PR it is
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@bocekm bocekm requested a review from danmyway November 22, 2024 20:47
@bocekm bocekm requested a review from a team as a code owner November 22, 2024 20:47
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (40f5d6e) to head (f9f0cd7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1435   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          72       72           
  Lines        5142     5146    +4     
  Branches      888      889    +1     
=======================================
+ Hits         4941     4945    +4     
  Misses        119      119           
  Partials       82       82           
Flag Coverage Δ
centos-linux-7 91.58% <100.00%> (+<0.01%) ⬆️
centos-linux-8 92.44% <100.00%> (+<0.01%) ⬆️
centos-linux-9 92.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bocekm bocekm force-pushed the dont-update-rhsm-facts-without-sub-man branch 2 times, most recently from b2ab5af to 47a424f Compare November 26, 2024 16:18
@bocekm bocekm requested a review from a team as a code owner November 26, 2024 16:18
@bocekm bocekm added the tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. label Nov 26, 2024
@has-bot
Copy link
Member

has-bot commented Nov 26, 2024

/packit test --labels tier0


Comment generated by an automation.

@danmyway
Copy link
Member

/packit test --labels tier0

When an exception was raised early before we had a change to install sub-mand, we've
seen a traceback due to trying to call sub-man which hasn't been installed.
@danmyway danmyway force-pushed the dont-update-rhsm-facts-without-sub-man branch from 47a424f to f9f0cd7 Compare November 27, 2024 14:32
@danmyway danmyway merged commit bd97afb into oamg:main Nov 27, 2024
15 of 18 checks passed
@bocekm bocekm changed the title [RHELC-1728] Don't update RHSM facts without sub-man installed [RHELC-1728] Prevent updating RHSM facts without sub-man being installed Nov 28, 2024
@bocekm bocekm changed the title [RHELC-1728] Prevent updating RHSM facts without sub-man being installed [RHELC-1728] Don't update RHSM facts with sub-man not present Nov 28, 2024
@bocekm bocekm mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed need-integration-tests tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants