-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1725] Include EUS/ELS switches in breadcrumbs #1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, revert the change on convert2rhel/unit_tests/toolopts/config_test.py
f208bdf
to
f6b8af8
Compare
Done |
99c0b39
to
9369ea5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 71 71
Lines 5090 5097 +7
Branches 880 882 +2
=======================================
+ Hits 4916 4923 +7
Misses 98 98
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dc4a538
to
1c433d3
Compare
/packit test --labels sanity |
1c433d3
to
6bda68b
Compare
This PR adds the
non_default_channel
to our rhsm custom facts so we can properly record metrics on the use of EUS/ELS during conversions.Jira Issues:
Checklist
[RHELC-]
or[HMS-]
is part of the PR titleRelease Pending
if relevant