Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1725] Include EUS/ELS switches in breadcrumbs #1395

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

pr-watson
Copy link
Contributor

@pr-watson pr-watson commented Oct 1, 2024

This PR adds the non_default_channel to our rhsm custom facts so we can properly record metrics on the use of EUS/ELS during conversions.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@pr-watson pr-watson requested a review from a team as a code owner October 1, 2024 14:45
Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, revert the change on convert2rhel/unit_tests/toolopts/config_test.py

@r0x0d r0x0d added kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. labels Oct 1, 2024
@has-bot
Copy link
Member

has-bot commented Oct 1, 2024

/packit test --labels sanity


Comment generated by an automation.

@pr-watson pr-watson force-pushed the update-rhsm-custom-facts branch from f208bdf to f6b8af8 Compare October 1, 2024 14:58
@pr-watson
Copy link
Contributor Author

please, revert the change on convert2rhel/unit_tests/toolopts/config_test.py

Done

@Venefilyn Venefilyn enabled auto-merge (rebase) October 4, 2024 11:22
@pr-watson pr-watson force-pushed the update-rhsm-custom-facts branch from 99c0b39 to 9369ea5 Compare October 8, 2024 19:50
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (e4d6c93) to head (6bda68b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1395   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files          71       71           
  Lines        5090     5097    +7     
  Branches      880      882    +2     
=======================================
+ Hits         4916     4923    +7     
  Misses         98       98           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 92.04% <100.00%> (+0.01%) ⬆️
centos-linux-8 92.91% <100.00%> (+<0.01%) ⬆️
centos-linux-9 93.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r0x0d r0x0d force-pushed the update-rhsm-custom-facts branch from dc4a538 to 1c433d3 Compare October 11, 2024 11:31
@r0x0d r0x0d disabled auto-merge October 11, 2024 11:31
@Venefilyn
Copy link
Member

/packit test --labels sanity

@Venefilyn Venefilyn force-pushed the update-rhsm-custom-facts branch from 1c433d3 to 6bda68b Compare October 16, 2024 13:36
@pr-watson pr-watson merged commit 0ec324a into oamg:main Oct 16, 2024
18 checks passed
@bocekm bocekm changed the title [RHELC-1725] Update rhsm custom facts [RHELC-1725] Include EUS/ELS switches in breadcrumbs Nov 28, 2024
@bocekm bocekm mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants