-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHELC-1677] Fix missing /etc/yum.repos.d/ directory on EL9 #1389
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1389 +/- ##
=======================================
Coverage 96.57% 96.58%
=======================================
Files 71 71
Lines 5082 5090 +8
Branches 879 880 +1
=======================================
+ Hits 4908 4916 +8
Misses 98 98
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
96a5bc4
to
6d75f83
Compare
/packit test --labels sanity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one small comment.
520025a
to
2c0cce4
Compare
/packit test --labels sanity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QE Ack
Can fix merge conflicts and merge (without checking if test pass) If it breaks due to the merge conflict resolve in a different PR we can fix, but likely is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nitpicks, not a blocker.
e104702
to
758f730
Compare
Some packages (e.g. rocky-release or alma-release on EL9) can remove repository directory as their part. Without the directory, sub-man is unable to generate redhat.repo file. This results in inaccessibility of all rhel repositories.
9395fff
to
3950ac8
Compare
Some packages (e.g. rocky-release or alma-release on EL9) can remove repository directory as their part. Without the directory, sub-man is unable to generate redhat.repo file. This results in inaccessibility of all rhel repositories.
Jira Issues:
Checklist
[RHELC-]
or[HMS-]
is part of the PR titleRelease Pending
if relevant