Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1677] Fix missing /etc/yum.repos.d/ directory on EL9 #1389

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hosekadam
Copy link
Member

Some packages (e.g. rocky-release or alma-release on EL9) can remove repository directory as their part. Without the directory, sub-man is unable to generate redhat.repo file. This results in inaccessibility of all rhel repositories.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@hosekadam hosekadam requested review from a team as code owners September 25, 2024 14:54
@hosekadam hosekadam requested a review from danmyway September 25, 2024 14:54
@hosekadam hosekadam added the kind/bug-fix A bug has been fixed label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (da9502d) to head (3950ac8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1389   +/-   ##
=======================================
  Coverage   96.57%   96.58%           
=======================================
  Files          71       71           
  Lines        5082     5090    +8     
  Branches      879      880    +1     
=======================================
+ Hits         4908     4916    +8     
  Misses         98       98           
  Partials       76       76           
Flag Coverage Δ
centos-linux-7 92.03% <100.00%> (+0.01%) ⬆️
centos-linux-8 92.90% <100.00%> (+0.01%) ⬆️
centos-linux-9 93.02% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hosekadam hosekadam added the tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. label Sep 25, 2024
@has-bot
Copy link
Member

has-bot commented Sep 25, 2024

/packit test --labels tier0


Comment generated by an automation.

@hosekadam hosekadam added tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. and removed tests/tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. labels Sep 25, 2024
@has-bot
Copy link
Member

has-bot commented Sep 25, 2024

/packit test --labels sanity


Comment generated by an automation.

@hosekadam
Copy link
Member Author

/packit test --labels sanity

Copy link
Member

@r0x0d r0x0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small comment.

@hosekadam hosekadam force-pushed the fix-removed-repodir branch 2 times, most recently from 520025a to 2c0cce4 Compare September 30, 2024 10:17
@hosekadam
Copy link
Member Author

/packit test --labels sanity

Copy link
Member

@kokesak kokesak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE Ack

@Venefilyn
Copy link
Member

Can fix merge conflicts and merge (without checking if test pass)

If it breaks due to the merge conflict resolve in a different PR we can fix, but likely is fine

Copy link
Member

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nitpicks, not a blocker.

convert2rhel/actions/pre_ponr_changes/handle_packages.py Outdated Show resolved Hide resolved
convert2rhel/actions/pre_ponr_changes/handle_packages.py Outdated Show resolved Hide resolved
@hosekadam hosekadam force-pushed the fix-removed-repodir branch 2 times, most recently from e104702 to 758f730 Compare October 9, 2024 14:35
Some packages (e.g. rocky-release or alma-release on EL9) can remove
repository directory as their part. Without the directory, sub-man is
unable to generate redhat.repo file. This results in inaccessibility of
all rhel repositories.
@Venefilyn Venefilyn force-pushed the fix-removed-repodir branch from 9395fff to 3950ac8 Compare October 9, 2024 19:02
@Venefilyn Venefilyn enabled auto-merge (rebase) October 9, 2024 19:02
@Venefilyn Venefilyn merged commit 80d9a2d into oamg:main Oct 9, 2024
15 of 18 checks passed
@bocekm bocekm changed the title [RHELC-1677] Fix missing repository directory [RHELC-1677] Fix missing /etc/yum.repos.d/ directory on EL9 Nov 28, 2024
@bocekm bocekm mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants