Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHELC-1675] Handle failing duplicate package check on EL9 #1363

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

pr-watson
Copy link
Contributor

@pr-watson pr-watson commented Aug 29, 2024

This PR modifies the condition to handle duplicate package error results to also work when run on an el9 system. New unit tests have been added for the el9 scenarios.

Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-] or [HMS-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@pr-watson pr-watson added bug Something isn't working tests/all Run the full test suite. Equivalent to `/packit test`. labels Aug 29, 2024
@pr-watson pr-watson requested a review from a team as a code owner August 29, 2024 14:23
@has-bot
Copy link
Member

has-bot commented Aug 29, 2024

/packit test


Comment generated by an automation.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (38311a8) to head (9920f3e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1363   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files          66       66           
  Lines        4997     4997           
  Branches      877      877           
=======================================
  Hits         4819     4819           
  Misses        101      101           
  Partials       77       77           
Flag Coverage Δ
centos-linux-7 91.86% <100.00%> (ø)
centos-linux-8 92.75% <100.00%> (ø)
centos-linux-9 92.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comment

convert2rhel/actions/system_checks/duplicate_packages.py Outdated Show resolved Hide resolved
@pr-watson pr-watson force-pushed the dup-packages-return-code branch from 2d34067 to bfee688 Compare September 3, 2024 13:46
@pr-watson
Copy link
Contributor Author

/packit test

@Venefilyn
Copy link
Member

/packit test

@pr-watson
Copy link
Contributor Author

/packit build

@pr-watson pr-watson force-pushed the dup-packages-return-code branch from bfee688 to bbb1ea6 Compare September 4, 2024 14:05
@Venefilyn
Copy link
Member

/packit test

@pr-watson
Copy link
Contributor Author

/packit build

@pr-watson
Copy link
Contributor Author

/packit test

@r0x0d r0x0d force-pushed the dup-packages-return-code branch from bbb1ea6 to 9920f3e Compare September 9, 2024 17:14
@r0x0d r0x0d added tests/tier1 Run (optional) tier1 test jobs. Equivalent to `/packit test --labels tier1`. and removed tests/all Run the full test suite. Equivalent to `/packit test`. labels Sep 9, 2024
@has-bot
Copy link
Member

has-bot commented Sep 9, 2024

/packit test --labels tier1


Comment generated by an automation.

@Venefilyn Venefilyn added kind/bug-fix A bug has been fixed and removed bug Something isn't working labels Sep 10, 2024
@Venefilyn
Copy link
Member

/packit test --labels tier1

@Venefilyn Venefilyn merged commit 841cf50 into oamg:main Sep 13, 2024
37 of 41 checks passed
@bocekm bocekm changed the title [RHELC-1675] Add handling for rhel9 systems in duplicate package check [RHELC-1675] Handle failing duplicate package check on EL9 Nov 28, 2024
@bocekm bocekm mentioned this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix A bug has been fixed tests/tier1 Run (optional) tier1 test jobs. Equivalent to `/packit test --labels tier1`.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants