[RHELC-788] Implement integration test error after ponr #1265

SerCantus · 2024-06-18T08:34:45Z

Implement a new integration test to verify the log message when a fail occurs after PONR

Jira Issues:

RHELC-788

Checklist

PR has been tested manually in a VM (either author or reviewer)
Jira issue has been made public if possible
[RHELC-] or [HMS-] is part of the PR title
GitHub label has been added to help with Release notes
PR title explains the change from the user's point of view
Code and tests are documented properly
The commits are squashed to as few commits as possible (without losing data)
When merged: Jira issue has been updated to Release Pending if relevant

codecov · 2024-06-18T08:36:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (bd8b563) to head (76087fb).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          71       71           
  Lines        5077     5077           
  Branches      883      883           
=======================================
  Hits         4900     4900           
  Misses         98       98           
  Partials       79       79

Flag	Coverage Δ
centos-linux-7	`92.01% <ø> (ø)`
centos-linux-8	`92.88% <ø> (ø)`
centos-linux-9	`92.92% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danmyway

Looks great, just a couple of adjustments requested.
Also, please just switch test-coverage-enhancement label for no-changelog, the enhancement serves for larger introductions, we don't use it for single tests :)

plans/tier1.fmf

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py

has-bot · 2024-07-12T08:44:00Z

/packit test --labels sanity

Comment generated by an automation.

Log | Bot Usage

danmyway

Looks good now, great job!
Thanks @SerCantus

danmyway · 2024-08-14T13:23:22Z

/packit test --labels tier1

danmyway · 2024-08-19T11:35:50Z

Needs a rebase and a test re-run.
Whenever you're available, please, @SerCantus

SerCantus · 2024-08-26T10:14:06Z

/packit test --labels tier1

kokesak

Looks promising, the test will fail now due to subman registration error. We should hold this PR open till it is working again

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py

plans/tier1.fmf

SerCantus · 2024-08-28T13:58:12Z

/packit test --labels tier1

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py

SerCantus · 2024-09-05T14:44:29Z

/packit test --labels tier1

kokesak · 2024-09-06T08:18:15Z

Seems like that the conversion works fine - no error happens. I went over the logs, and it seems that the echo command happens quite late. It sadly is executed after the conf patch:

[2024-09-05T15:16:47+0000] TASK - [Convert: Patch package manager configuration file] ****************
[2024-09-05T15:16:47+0000] DEBUG - Calling command 'rpm -Vf /etc/yum.conf'

Executing a command:
echo "proxy=localhost" >> /etc/yum.conf


/etc/yum.conf patched.
CONFIGURE_PKG_MANAGER has succeeded

I suggest doing it much sooner, if you put it just after the
"WARNING - The tool allows rollback of any action until this point." then the error does not happen?

SerCantus · 2024-09-09T10:02:08Z

Seems like that the conversion works fine - no error happens. I went over the logs, and it seems that the echo command happens quite late. It sadly is executed after the conf patch:
[2024-09-05T15:16:47+0000] TASK - [Convert: Patch package manager configuration file] ****************
[2024-09-05T15:16:47+0000] DEBUG - Calling command 'rpm -Vf /etc/yum.conf'

Executing a command:
echo "proxy=localhost" >> /etc/yum.conf


/etc/yum.conf patched.
CONFIGURE_PKG_MANAGER has succeeded
I suggest doing it much sooner, if you put it just after the "WARNING - The tool allows rollback of any action until this point." then the error does not happen?

The issue with this test is that it only fails on automated executions. When I try to so it manually it always passes so I'm lost. I will try your approach.

danmyway · 2024-09-27T05:41:21Z

/packit test --labels tier1

kokesak · 2024-09-27T07:15:30Z

/packit test --labels tier1

tests/integration/tier1/destructive/error-after-ponr/main.fmf

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py

kokesak · 2024-09-27T07:53:57Z

/packit test --labels tier1

kokesak · 2024-09-27T10:51:22Z

Tier1 is failing now due to the "/plans/tier1/destructive/modified_grub_file/changed_grub_invalid fail" being obsoloete after recent changes. Once this gets fixed, we can re-run the tests here #1391

kokesak · 2024-09-30T06:30:26Z

/packit test --labels tier1

kokesak · 2024-09-30T10:07:21Z

/packit test --labels tier1

kokesak · 2024-09-30T13:04:07Z

/packit test --labels tier1

Apply suggestions from code review Co-authored-by: Daniel Diblik <[email protected]> Add comment to new test discover [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Add assert for a shell invoke and indentation to comment Co-authored-by: Martin "kokesak" Litwora <[email protected]> Update test_error_after_ponr with new TEST_VARS naming Co-authored-by: Daniel Diblik <[email protected]> Update how to trigger the PONR failure in the test [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Change the source of the error - internet connection after PONR

kokesak · 2024-10-02T07:48:17Z

/packit test --labels tier1

plans/tier1.fmf

Co-authored-by: Daniel Diblik <[email protected]>

kokesak

LGTM

SerCantus added the kind/tests Improvement or enhancement of the tests label Jun 18, 2024

SerCantus requested a review from danmyway June 18, 2024 08:34

SerCantus self-assigned this Jun 18, 2024

danmyway requested changes Jun 19, 2024

View reviewed changes

SerCantus added the tests/sanity PR ready to run the sanity test suit. Equivalent to `/packit test --labels sanity`. label Jul 12, 2024

SerCantus requested a review from danmyway July 31, 2024 14:35

danmyway approved these changes Aug 14, 2024

View reviewed changes

danmyway added skip/changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. and removed kind/tests Improvement or enhancement of the tests labels Aug 14, 2024

SerCantus force-pushed the test-error-after-ponr branch from 7c1c16d to 016262e Compare August 26, 2024 09:57

SerCantus requested a review from a team as a code owner August 26, 2024 09:57

SerCantus requested a review from kokesak August 26, 2024 09:57

kokesak requested changes Aug 26, 2024

View reviewed changes

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py Outdated Show resolved Hide resolved

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py Outdated Show resolved Hide resolved

plans/tier1.fmf Show resolved Hide resolved

danmyway requested changes Sep 3, 2024

View reviewed changes

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Sep 3, 2024

View reviewed changes

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py Fixed Show fixed Hide fixed

kokesak force-pushed the test-error-after-ponr branch from 8af878d to 91c7f0c Compare September 27, 2024 07:07

kokesak reviewed Sep 27, 2024

View reviewed changes

tests/integration/tier1/destructive/error-after-ponr/main.fmf Outdated Show resolved Hide resolved

kokesak reviewed Sep 27, 2024

View reviewed changes

tests/integration/tier1/destructive/error-after-ponr/test_error_after_ponr.py Outdated Show resolved Hide resolved

kokesak force-pushed the test-error-after-ponr branch from 91c7f0c to a5dd447 Compare September 27, 2024 07:27

kokesak requested a review from danmyway September 27, 2024 07:27

kokesak force-pushed the test-error-after-ponr branch from a5dd447 to d0eab54 Compare September 30, 2024 06:26

kokesak force-pushed the test-error-after-ponr branch from d0eab54 to 94cab6a Compare September 30, 2024 09:56

kokesak force-pushed the test-error-after-ponr branch from 94cab6a to 8bbd470 Compare September 30, 2024 12:37

SerCantus and others added 2 commits October 2, 2024 09:40

Fix config_file test

6b1533e

kokesak force-pushed the test-error-after-ponr branch from 8bbd470 to 6b1533e Compare October 2, 2024 07:40

danmyway reviewed Oct 2, 2024

View reviewed changes

plans/tier1.fmf Outdated Show resolved Hide resolved

Update plans/tier1.fmf

76087fb

Co-authored-by: Daniel Diblik <[email protected]>

kokesak approved these changes Oct 2, 2024

View reviewed changes

kokesak enabled auto-merge (squash) October 2, 2024 15:33

danmyway approved these changes Oct 2, 2024

View reviewed changes

kokesak merged commit 04b7e8a into oamg:main Oct 2, 2024
15 of 18 checks passed

bocekm mentioned this pull request Nov 28, 2024

Bump version to 2.2.0 #1441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RHELC-788] Implement integration test error after ponr #1265

[RHELC-788] Implement integration test error after ponr #1265

SerCantus commented Jun 18, 2024 •

edited

Loading

codecov bot commented Jun 18, 2024 •

edited

Loading

danmyway left a comment

has-bot commented Jul 12, 2024

danmyway left a comment

danmyway commented Aug 14, 2024

danmyway commented Aug 19, 2024

SerCantus commented Aug 26, 2024

kokesak left a comment

SerCantus commented Aug 28, 2024

SerCantus commented Sep 5, 2024

kokesak commented Sep 6, 2024

SerCantus commented Sep 9, 2024

danmyway commented Sep 27, 2024

kokesak commented Sep 27, 2024

kokesak commented Sep 27, 2024

kokesak commented Sep 27, 2024 •

edited

Loading

kokesak commented Sep 30, 2024

kokesak commented Sep 30, 2024

kokesak commented Sep 30, 2024

kokesak commented Oct 2, 2024

kokesak left a comment

[RHELC-788] Implement integration test error after ponr #1265

[RHELC-788] Implement integration test error after ponr #1265

Conversation

SerCantus commented Jun 18, 2024 • edited Loading

codecov bot commented Jun 18, 2024 • edited Loading

Codecov Report

danmyway left a comment

Choose a reason for hiding this comment

has-bot commented Jul 12, 2024

danmyway left a comment

Choose a reason for hiding this comment

danmyway commented Aug 14, 2024

danmyway commented Aug 19, 2024

SerCantus commented Aug 26, 2024

kokesak left a comment

Choose a reason for hiding this comment

SerCantus commented Aug 28, 2024

SerCantus commented Sep 5, 2024

kokesak commented Sep 6, 2024

SerCantus commented Sep 9, 2024

danmyway commented Sep 27, 2024

kokesak commented Sep 27, 2024

kokesak commented Sep 27, 2024

kokesak commented Sep 27, 2024 • edited Loading

kokesak commented Sep 30, 2024

kokesak commented Sep 30, 2024

kokesak commented Sep 30, 2024

kokesak commented Oct 2, 2024

kokesak left a comment

Choose a reason for hiding this comment

SerCantus commented Jun 18, 2024 •

edited

Loading

codecov bot commented Jun 18, 2024 •

edited

Loading

kokesak commented Sep 27, 2024 •

edited

Loading