Added password reset features for tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brecke
reviewed
Jun 20, 2017
lib/api.authentication.js
Outdated
| * @param {Object} callback.err An error that occurred, if any | ||
| */ | ||
| var getResetPasswordSecret = module.exports.getResetPasswordSecret = function(restCtx, username, callback) { | ||
| RestUtil.RestRequest(restCtx, '/api/auth/local/reset/init/' + username, 'GET', null, callback); |
There was a problem hiding this comment.
I'd suggest /api/auth/local/reset/password-secret since REST endpoints' resources should be nouns and not verbs.. also, we don't need the / do we?
There was a problem hiding this comment.
That'll require me changing it in Hilary, 3akai as well so will take a bit longer. I'll go with /api/auth/local/reset/secret.
Also, I'm not sure which / you mean... We do need the ones here.
There was a problem hiding this comment.
secret is fine. And nevermind about the slashes, I misread the concatenation at the end
lib/api.authentication.js
Outdated
| * @param {Object} callback.err An error that occurred, if any | ||
| */ | ||
| var resetPassword = module.exports.resetPassword = function(restCtx, username, secret, newPassword, callback) { | ||
| RestUtil.RestRequest(restCtx, '/api/auth/local/reset/change/' + username, 'POST', {'secret': secret, 'newPassword': newPassword}, callback); |
There was a problem hiding this comment.
Let's make it /api/auth/local/reset/password since that's the resource we're manipulating
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.