Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the basic auth entry validation bits. The underlying problem is #1249

Merged
merged 11 commits into from
Mar 1, 2025

Conversation

david-fisher
Copy link
Contributor

Chrome + BasicAuth url user:pass@host is a no go.

Turns off the warning re: special characters in the basic auth entry.

Description

Motivation and Context

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

…s Chrome + BasicAuth url user:pass@host is a no go.
@david-fisher david-fisher requested a review from epugh February 28, 2025 16:06
Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some polish in messaging like showing the user auth in curl if you have one, and a chrome specific messaging. bump to new splainer

@epugh epugh merged commit d33abc4 into main Mar 1, 2025
4 of 5 checks passed
@epugh
Copy link
Member

epugh commented Mar 1, 2025

Fixes #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants