remove method that was only used in testing (#173)

o19s · Jul 9, 2020 · cce8be8 · cce8be8
1 parent 11922b8
commit cce8be8
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 32 deletions.
diff --git a/app/assets/javascripts/services/caseSvc.js b/app/assets/javascripts/services/caseSvc.js
@@ -160,19 +160,6 @@ angular.module('QuepidApp')
         return selectedCase;
       };
 
-      this.getCaseByNo = function(caseNo) {
-        console.log('I AM A DEAD METHOD UNLESS YOU SEE ME!');
-        var returnedCase = null;
-
-        angular.forEach(this.allCases, function(aCase) {
-          if (aCase.caseNo === caseNo) {
-            returnedCase = aCase;
-          }
-        });
-
-        return returnedCase;
-      };
-
       this.createCase = function(caseName, queries, tries) {
         // http post /cases/
         // returns as if we did http get /cases/<caseNo>

diff --git a/spec/javascripts/angular/services/caseSvc_spec.js b/spec/javascripts/angular/services/caseSvc_spec.js
@@ -5,14 +5,16 @@ describe('Service: caseSvc', function () {
   // load the service's module
   beforeEach(module('QuepidTest'));
 
+  var mockCase1 = {
+    'caseNo':   1,
+    'case_name': 'test case',
+    'lastTry':  4,
+    'owned':    true
+  };
+
   var mockCases = {
     allCases: [
-      {
-        'caseNo':   1,
-        'case_name': 'test case',
-        'lastTry':  4,
-        'owned':    true
-      },
+      mockCase1,
       {
         'caseNo':   2,
         'case_name': 'test case 2',
@@ -83,6 +85,8 @@ describe('Service: caseSvc', function () {
       $httpBackend.expectGET('/api/cases').respond(200, mockCases);
       $httpBackend.expectGET('/api/dropdown/cases').respond(200, mockCases);
 
+
+
       caseSvc.uponBeingBootstrapped().
         then(function() {
           expect(caseSvc.allCases.length).toBe(4);
@@ -192,22 +196,22 @@ describe('Service: caseSvc', function () {
     });
 
     it('gets a case by number', function() {
-      var caseNoOne = caseSvc.getCaseByNo(1);
-      expect(caseNoOne.caseName).toEqual('test case');
+      $httpBackend.expectGET('/api/cases/1').respond(200, mockCase1);
+      caseSvc.get(1,false).then(function(acase) {
+        expect(acase.caseName).toEqual('test case');
+      });
+      $httpBackend.flush();
     });
 
-    it('gets null if case number not present', function() {
-      var caseNoZero = caseSvc.getCaseByNo(0);
-      expect(caseNoZero).toEqual(null);
-      var caseNoOneK = caseSvc.getCaseByNo(1000);
-      expect(caseNoOneK).toEqual(null);
-    });
 
     it('deletes a case', function() {
+      $httpBackend.expectGET('/api/cases/1').respond(200, mockCase1);
       $httpBackend.expectDELETE('/api/cases/1').respond(200, '');
       expectToRefetchCases();
 
-      caseSvc.deleteCase(caseSvc.getCaseByNo(1));
+      caseSvc.get(1,false).then(function(acase) {
+        caseSvc.deleteCase(acase);
+      });
 
       $httpBackend.flush();
 
@@ -222,11 +226,14 @@ describe('Service: caseSvc', function () {
     });
 
     it('deletes and calls promise', function(){
+      $httpBackend.expectGET('/api/cases/1').respond(200, mockCase1);
       $httpBackend.expectDELETE('/api/cases/1').respond(200, '');
       expectToRefetchCases();
       var called = false;
-      caseSvc.deleteCase(caseSvc.getCaseByNo(1)).then( function() {
-        called = true;
+      caseSvc.get(1,false).then(function(acase) {
+        caseSvc.deleteCase(acase).then( function() {
+          called = true;
+        });
       });
       $httpBackend.flush();
       expect(called).toEqual(true);
@@ -235,19 +242,25 @@ describe('Service: caseSvc', function () {
     it('deletes currently selected case, calls promise', function(){
       caseSvc.selectCase(1);
       expect(caseSvc.getSelectedCase().caseNo).toEqual(1);
+      $httpBackend.expectGET('/api/cases/1').respond(200, mockCase1);
       $httpBackend.expectDELETE('/api/cases/1').respond(200, '');
       expectToRefetchCases();
-      caseSvc.deleteCase(caseSvc.getCaseByNo(1));
+      caseSvc.get(1,false).then(function(acase) {
+        caseSvc.deleteCase(acase);
+      });
       $httpBackend.flush();
       expect(caseSvc.getSelectedCase()).toEqual(null);
     });
 
     it('deletes currently selected case, calls promise', function(){
       caseSvc.selectCase(2);
       expect(caseSvc.getSelectedCase().caseNo).toEqual(2);
+      $httpBackend.expectGET('/api/cases/1').respond(200, mockCase1);
       $httpBackend.expectDELETE('/api/cases/1').respond(200, '');
       expectToRefetchCases();
-      caseSvc.deleteCase(caseSvc.getCaseByNo(1));
+      caseSvc.get(1,false).then(function(acase) {
+        caseSvc.deleteCase(acase);
+      });
       $httpBackend.flush();
       expect(caseSvc.getSelectedCase().caseNo).toEqual(2);
     });