Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding timestamp to search events #42

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Adding timestamp to search events #42

merged 1 commit into from
Feb 17, 2024

Conversation

jzonthemtn
Copy link
Collaborator

@jzonthemtn jzonthemtn commented Feb 16, 2024

For #4, adds a timestamp to search events. The timestamp in the search response below.

{
  "took": 3,
  "timed_out": false,
  "_shards": {
    "total": 1,
    "successful": 1,
    "skipped": 0,
    "failed": 0
  },
  "hits": {
    "total": {
      "value": 1,
      "relation": "eq"
    },
    "max_score": 1,
    "hits": [
      {
        "_index": ".awesome_queries",
        "_id": "1xo5s40BIxD0OQiiKYL8",
        "_score": 1,
        "_source": {
          "queryResponseHitIds": [
            "0"
          ],
          "queryResponseId": "a8f83e83-2904-4a2b-ad24-df64bb9022bc",
          "query": "{}",
          "timestamp": 1708108882938,
          "queryId": "0e96d884-a584-431e-b934-761fc71d579d"
        }
      }
    ]
  }
}

Copy link
Member

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

When do we start having some sort of testing? Maybe when we have a more formal specification?

@jzonthemtn jzonthemtn merged commit 98a0099 into main Feb 17, 2024
1 check passed
@jzonthemtn jzonthemtn deleted the timestamps branch February 17, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants