Caching index settings #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epugh
approved these changes
Mar 7, 2024
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.*; |
There was a problem hiding this comment.
Is * a normal pattern in OPenSearch? (would not be in Solr!)
There was a problem hiding this comment.
Not sure, but I don't like it either. Will update.
There was a problem hiding this comment.
Turned out to be several instances of it so I fixed them all. There's a setting in IntelliJ to not let it do that to imports.
|
@jzonthemtn looks good except one import nit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #92, cache index settings to avoid looking at the index to find the settings. This is to avoid unnecessary roundtrips when logging queries.
Upon first query, the settings are retrieved from the index. For queries after that, the setting is retrieved from the cache:
After the store is deleted and recreated, the next search will get the settings from the index since the cache has been cleared.