Change the install script to be easier to run #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Pugh <[email protected]>
jzonthemtn
approved these changes
Nov 23, 2024
jzonthemtn
reviewed
Nov 23, 2024
| @@ -5,21 +5,28 @@ MAJOR='\033[0;34m' | |||
| MINOR='\033[0;37m ' | |||
| RESET='\033[0m' # No Color | |||
|
|
|||
| : ${OPEN_SEARCH:="localhost:9200"} | |||
There was a problem hiding this comment.
You can do this if you want default values:
OPEN_SEARCH=${1:-"default value if not provided"}
OPEN_SEARCH_DASHBOARDS=${2:-"default value if not provided"}
There was a problem hiding this comment.
i kinda just prefer variables... versus environment variables... for explicitness...
There was a problem hiding this comment.
Those are local variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to integrate the script into some other processes, so making it take explicit parameters will simplify passing in the urls, especially if they are on https.