Renaming queryResponseObjectIds to queryResponseHitIds.

Signed-off-by: jzonthemtn <[email protected]>
o19s · Dec 5, 2024 · e0e7cd5 · e0e7cd5
1 parent 8dc72e9
commit e0e7cd5
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/...ion-plugin/src/main/java/org/opensearch/eval/judgments/model/ubi/query/QueryResponse.java b/...ion-plugin/src/main/java/org/opensearch/eval/judgments/model/ubi/query/QueryResponse.java
@@ -17,18 +17,18 @@ public class QueryResponse {
 
     private final String queryId;
     private final String queryResponseId;
-    private final List<String> queryResponseObjectIds;
+    private final List<String> queryResponseHitIds;
 
     /**
      * Creates a query response.
      * @param queryId The ID of the query.
      * @param queryResponseId The ID of the query response.
-     * @param queryResponseObjectIds A list of IDs for the hits in the query.
+     * @param queryResponseHitIds A list of IDs for the hits in the query.
      */
-    public QueryResponse(final String queryId, final String queryResponseId, final List<String> queryResponseObjectIds) {
+    public QueryResponse(final String queryId, final String queryResponseId, final List<String> queryResponseHitIds) {
         this.queryId = queryId;
         this.queryResponseId = queryResponseId;
-        this.queryResponseObjectIds = queryResponseObjectIds;
+        this.queryResponseHitIds = queryResponseHitIds;
     }
 
     /**
@@ -51,8 +51,8 @@ public String getQueryResponseId() {
      * Gets the list of query response hit IDs.
      * @return A list of query response hit IDs.
      */
-    public List<String> getQueryResponseObjectIds() {
-        return queryResponseObjectIds;
+    public List<String> getQueryResponseHitIds() {
+        return queryResponseHitIds;
     }
 
 }
diff --git a/...ation-plugin/src/main/java/org/opensearch/eval/judgments/opensearch/OpenSearchHelper.java b/...ation-plugin/src/main/java/org/opensearch/eval/judgments/opensearch/OpenSearchHelper.java
@@ -234,9 +234,9 @@ public long getCountOfQueriesForUserQueryHavingResultInRankR(final String userQu
 
         for(final SearchHit searchHit : response.getHits().getHits()) {
 
-            final List<String> queryResponseObjectIds = (List<String>) searchHit.getSourceAsMap().get("query_response_object_ids");
+            final List<String> queryResponseHidsIds = (List<String>) searchHit.getSourceAsMap().get("query_response_hit_ids");
 
-            if(queryResponseObjectIds.get(rank).equals(objectId)) {
+            if(queryResponseHidsIds.get(rank).equals(objectId)) {
                 countOfTimesShownAtRank++;
             }
 

diff --git a/...lity-evaluation/src/main/java/org/opensearch/eval/engine/opensearch/OpenSearchHelper.java b/...lity-evaluation/src/main/java/org/opensearch/eval/engine/opensearch/OpenSearchHelper.java
@@ -106,9 +106,9 @@ public int getCountOfQueriesForUserQueryHavingResultInRankR(final String userQue
 
         for(final SearchHit searchHit : response.getHits().getHits()) {
 
-            final List<String> queryResponseObjectIds = (List<String>) searchHit.getSourceAsMap().get("query_response_object_ids");
+            final List<String> queryResponseHitIds = (List<String>) searchHit.getSourceAsMap().get("query_response_hit_ids");
 
-            if(queryResponseObjectIds.get(rank).equals(objectId)) {
+            if(queryResponseHitIds.get(rank).equals(objectId)) {
                 countOfTimesShownAtRank++;
             }
 

diff --git a/...h-quality-evaluation/src/main/java/org/opensearch/eval/model/ubi/query/QueryResponse.java b/...h-quality-evaluation/src/main/java/org/opensearch/eval/model/ubi/query/QueryResponse.java
@@ -9,18 +9,18 @@ public class QueryResponse {
 
     private final String queryId;
     private final String queryResponseId;
-    private final List<String> queryResponseObjectIds;
+    private final List<String> queryResponseHitIds;
 
     /**
      * Creates a query response.
      * @param queryId The ID of the query.
      * @param queryResponseId The ID of the query response.
-     * @param queryResponseObjectIds A list of IDs for the hits in the query.
+     * @param queryResponseHitIds A list of IDs for the hits in the query.
      */
-    public QueryResponse(final String queryId, final String queryResponseId, final List<String> queryResponseObjectIds) {
+    public QueryResponse(final String queryId, final String queryResponseId, final List<String> queryResponseHitIds) {
         this.queryId = queryId;
         this.queryResponseId = queryResponseId;
-        this.queryResponseObjectIds = queryResponseObjectIds;
+        this.queryResponseHitIds = queryResponseHitIds;
     }
 
     /**
@@ -43,8 +43,8 @@ public String getQueryResponseId() {
      * Gets the list of query response hit IDs.
      * @return A list of query response hit IDs.
      */
-    public List<String> getQueryResponseObjectIds() {
-        return queryResponseObjectIds;
+    public List<String> getQueryResponseHitIds() {
+        return queryResponseHitIds;
     }
 
 }