Marc/lookup verif #3036
Open
Marc/lookup verif #3036
+231
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcbeunardeau88
force-pushed
the
marc/lookup-verif
branch
from
24f7bc5 to
dd1d6cf
Compare
| @@ -120,7 +120,7 @@ where | |||
| // -- Preparing for opening proof verification | |||
| let zeta_chal = ScalarChallenge(fq_sponge.challenge()); | |||
| let (_, endo_r) = G::endos(); | |||
| let zeta: G::ScalarField = zeta_chal.to_field(endo_r); | |||
There was a problem hiding this comment.
Sry, a nit got mixed up in the commit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## marc/lookup-prover #3036 +/- ##
======================================================
- Coverage 76.46% 76.21% -0.26%
======================================================
Files 263 264 +1
Lines 62170 62343 +173
======================================================
- Hits 47540 47512 -28
- Misses 14630 14831 +201 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the lookup verifier
Still a lot of cloning to be removed in a follow-up
Note that it is untested so probably wrong
Using it in the main will come in a follow-up