Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add open mips tests #2926

Merged
merged 5 commits into from
Jan 7, 2025
Merged

add open mips tests #2926

merged 5 commits into from
Jan 7, 2025

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Jan 6, 2025

  • added halt_address field to VmConfiguration as a way to test for program exit (same trick used by cannon to run open mips tests)
  • added test file test_mips_elf.rs and run all the (non oracle) tests in CI that aren't currently failing
  • added build mips action, change workflows to use this action since mips artifacts are needed when running complete test suite

Current (ignored) test failures that need to be addressed:

  • mul.asm: We have an overflow exception because we are trying to do signed integer multiplication with casting that leads to overflow
  • exit_group.asm: it's unclear to me what this program means, but the use of syscall is suspect

@martyall martyall force-pushed the martin/open-mips-tests branch 2 times, most recently from d1ccd4f to 4dbb046 Compare January 6, 2025 21:47
@martyall martyall force-pushed the martin/open-mips-tests branch from 4dbb046 to 849d9ae Compare January 6, 2025 21:48
@martyall martyall marked this pull request as ready for review January 6, 2025 21:54
@martyall martyall changed the title add basic open mips tests add open mips tests Jan 6, 2025
@martyall martyall closed this Jan 6, 2025
@martyall martyall reopened this Jan 6, 2025
@martyall martyall force-pushed the martin/open-mips-tests branch 2 times, most recently from a108b92 to 009da34 Compare January 7, 2025 17:00
@martyall martyall force-pushed the martin/open-mips-tests branch from 009da34 to 4fa1f26 Compare January 7, 2025 17:01
@martyall martyall requested a review from dannywillems January 7, 2025 17:29
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.31%. Comparing base (343132b) to head (4fa1f26).
Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/cli/cannon.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2926      +/-   ##
==========================================
+ Coverage   74.66%   76.31%   +1.65%     
==========================================
  Files         259      255       -4     
  Lines       61713    60839     -874     
==========================================
+ Hits        46075    46428     +353     
+ Misses      15638    14411    -1227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems merged commit 25a8372 into master Jan 7, 2025
8 checks passed
@dannywillems dannywillems deleted the martin/open-mips-tests branch January 7, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants