Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
halt_address
field toVmConfiguration
as a way to test for program exit (same trick used bycannon
to run open mips tests)test_mips_elf.rs
and run all the (non oracle) tests in CI that aren't currently failingCurrent (ignored) test failures that need to be addressed:
mul.asm
: We have an overflow exception because we are trying to do signed integer multiplication with casting that leads to overflowexit_group.asm
: it's unclear to me what this program means, but the use ofsyscall
is suspect