o1vm/riscv32i: introduce column module #2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2745 +/- ##
==========================================
- Coverage 73.69% 73.67% -0.02%
==========================================
Files 251 252 +1
Lines 57788 57801 +13
==========================================
- Hits 42584 42583 -1
- Misses 15204 15218 +14 ☔ View full report in Codecov by Sentry. |
svv232
reviewed
Nov 14, 2024
Comment on lines
+4
to
+9
| pub const SCRATCH_SIZE: usize = 20; | ||
|
|
||
| /// Number of instructions in the ISA | ||
| // FIXME: the value might not be correct. It will be updated when the | ||
| // interpreter is fully implemented. | ||
| pub const INSTRUCTION_SET_SIZE: usize = 47; |
There was a problem hiding this comment.
These values are currently too small to run with the interpreter, dynamic testing yielded an oob when running tests that are yet to be merged. I made them larger in https://github.com/o1-labs/proof-systems/pull/2754/files . We should fix these to be correct in a follow up later down the stack as also mentioned in #2754
svv232
approved these changes
Nov 14, 2024
Base automatically changed from
dw/o1vm-move-memory-size-top-level-dir
to
master
November 14, 2024 14:43
dannywillems
deleted the
dw/o1vm-riscv32i-introduce-scratch-size-column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.