Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/pickles: start ignoring some failing instructions while fixing #2725

Merged

Conversation

dannywillems
Copy link
Member

No description provided.

@dannywillems dannywillems force-pushed the dw/temporary-ignore-some-constraints branch from afb44ec to cb2b6f4 Compare October 20, 2024 09:58
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (c165230) to head (a8b3c10).
Report is 2 commits behind head on dw/fixup-step-snapshot.

Files with missing lines Patch % Lines
o1vm/src/pickles/main.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           dw/fixup-step-snapshot    #2725      +/-   ##
==========================================================
- Coverage                   72.54%   72.51%   -0.03%     
==========================================================
  Files                         247      247              
  Lines                       57691    57706      +15     
==========================================================
- Hits                        41850    41846       -4     
- Misses                      15841    15860      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems force-pushed the dw/temporary-ignore-some-constraints branch 2 times, most recently from 5fe0196 to 74ef2af Compare October 20, 2024 17:03
@dannywillems dannywillems force-pushed the dw/temporary-ignore-some-constraints branch from 74ef2af to 72ee86b Compare October 21, 2024 11:13
@dannywillems dannywillems force-pushed the dw/temporary-ignore-some-constraints branch from 72ee86b to a8b3c10 Compare October 21, 2024 11:15
@shimkiv shimkiv merged commit 7592142 into dw/fixup-step-snapshot Oct 21, 2024
6 checks passed
@shimkiv shimkiv deleted the dw/temporary-ignore-some-constraints branch October 21, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants