Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/snapshot: use normalized instruction counter #2723

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

dannywillems
Copy link
Member

The instruction counter is the one scaled by the maximum of read/write into memory/register.

The instruction counter is the one scaled by the maximum of read/write into
memory/register.
@dannywillems dannywillems marked this pull request as draft October 18, 2024 19:29
@dannywillems dannywillems requested a review from shimkiv October 18, 2024 19:36
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 72.52%. Comparing base (ae58bc5) to head (7592142).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/pickles/main.rs 0.00% 16 Missing ⚠️
o1vm/src/interpreters/mips/witness.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2723      +/-   ##
==========================================
- Coverage   72.52%   72.52%   -0.01%     
==========================================
  Files         247      247              
  Lines       57691    57706      +15     
==========================================
+ Hits        41843    41851       +8     
- Misses      15848    15855       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dannywillems dannywillems marked this pull request as ready for review October 20, 2024 09:16
@shimkiv shimkiv merged commit a0adb64 into master Oct 21, 2024
6 of 7 checks passed
@shimkiv shimkiv deleted the dw/fixup-step-snapshot branch October 21, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants