-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E o1VM testing with cached artifacts. #2700
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2700 +/- ##
==========================================
- Coverage 72.52% 72.49% -0.03%
==========================================
Files 247 247
Lines 57706 57716 +10
==========================================
- Hits 41851 41843 -8
- Misses 15855 15873 +18 ☔ View full report in Codecov by Sentry. |
3e42796
to
a339d26
Compare
@@ -77,7 +77,6 @@ jobs: | |||
# It might be related to boxroot dependency, and we would need to bump | |||
# up the ocaml-rs dependency | |||
ocaml_version: ["4.14"] | |||
os: ["ubuntu-latest"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for history: this is the line that seems to require changing the CI settings. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target OS is calculated dynamically and is not in use by strategy.matrix.os
so I removed it yet it messed the naming anyway. Weird.
Branching rules updated on master by removing
in addition to the new one
|
Closes #2693