Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E o1VM testing with cached artifacts. #2700

Merged
merged 23 commits into from
Oct 25, 2024
Merged

E2E o1VM testing with cached artifacts. #2700

merged 23 commits into from
Oct 25, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Oct 10, 2024

Closes #2693

@shimkiv shimkiv self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (7592142) to head (3e42796).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
o1vm/src/interpreters/mips/witness.rs 39.39% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2700      +/-   ##
==========================================
- Coverage   72.52%   72.49%   -0.03%     
==========================================
  Files         247      247              
  Lines       57706    57716      +10     
==========================================
- Hits        41851    41843       -8     
- Misses      15855    15873      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shimkiv shimkiv marked this pull request as ready for review October 21, 2024 13:17
@shimkiv
Copy link
Member Author

shimkiv commented Oct 21, 2024

o1vm/run-code.sh Outdated Show resolved Hide resolved
o1vm/run-vm.sh Outdated Show resolved Hide resolved
o1vm/run-vm.sh Outdated Show resolved Hide resolved
@shimkiv shimkiv requested a review from dannywillems October 22, 2024 10:37
@dannywillems
Copy link
Member

Reverting changes to @shimkiv last commit, i.e. a339d26. Let's stop pushing on other people branches.

@@ -77,7 +77,6 @@ jobs:
# It might be related to boxroot dependency, and we would need to bump
# up the ocaml-rs dependency
ocaml_version: ["4.14"]
os: ["ubuntu-latest"]
Copy link
Member

@dannywillems dannywillems Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for history: this is the line that seems to require changing the CI settings. LGTM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target OS is calculated dynamically and is not in use by strategy.matrix.os so I removed it yet it messed the naming anyway. Weird.

@dannywillems
Copy link
Member

dannywillems commented Oct 25, 2024

Branching rules updated on master by removing ubuntu-latest in the list, and listed as required:

CI / Run checks and tests (1.71, 4.14) (pull_request)
CI / Run checks and tests (1.72, 4.14) (pull_request)
CI / Run checks and tests (1.73, 4.14) (pull_request)
CI / Run checks and tests (1.74, 4.14) (pull_request)

in addition to the new one

o1vm CI / Run o1vm with cached data (1.74, 4.14) (pull_request)

@shimkiv shimkiv merged commit fffe917 into master Oct 25, 2024
14 of 15 checks passed
@shimkiv shimkiv deleted the test/o1vm-e2e branch October 25, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit the external dependencies to be used during the E2E testing (reuse oracle / block data)
2 participants