Arrabiata: define correctly the different challenges used in the protocol #2684
Conversation
dannywillems
force-pushed
the
dw/arrabiata-challenges-expressions
branch
from
2526618 to
e815585
Compare
The test is now working as the PR has been merged and we upgraded arkworks.
Respect Rust convention to move integration tests in a different subdirectory
dannywillems
force-pushed
the
dw/arrabiata-challenges-expressions
branch
from
2c94366 to
bde9704
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
- Coverage 72.60% 72.59% -0.01%
==========================================
Files 246 246
Lines 58154 58156 +2
==========================================
- Hits 42220 42219 -1
- Misses 15934 15937 +3 ☔ View full report in Codecov by Sentry. |
dannywillems
force-pushed
the
dw/arrabiata-challenges-expressions
branch
from
dd931a2 to
3e5f19f
Compare
| } | ||
|
|
||
| fn text(&self, _cache: &mut HashMap<CacheId, Self>) -> String { | ||
| let col = self.col.text(&mut HashMap::new()); |
There was a problem hiding this comment.
why isn't the cache in the arg of the function given as arg to the recursive call of text ?
There was a problem hiding this comment.
Not the same type, and also, it is unused in any case.
| @@ -3075,7 +3079,7 @@ where | |||
| }); | |||
| res | |||
| } | |||
| Atom(Cell(v)) => v.latex(), | |||
| Atom(Cell(v)) => v.latex(&mut HashMap::new()), | |||
There was a problem hiding this comment.
why isn't the cache in the arg of the function given as arg to the recursive call ?
There was a problem hiding this comment.
Not the same type, and also, it is unused in any case.
| @@ -3122,7 +3126,7 @@ where | |||
| }); | |||
| res | |||
| } | |||
| Atom(Cell(v)) => v.text(), | |||
| Atom(Cell(v)) => v.text(&mut HashMap::new()), | |||
There was a problem hiding this comment.
why isn't the cache in the arg of the function given as arg to the recursive call ?
There was a problem hiding this comment.
Not the same type, and also, it is unused in any case.
I also added some changes in Kimchi. Lemme know if a different PR is required. I splitted the changes in different clean commits.
Fix #2685