Revisit 2278: Unify hash digest format on both sides (MIPS + Keccak) #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+48
to
+50
| // MIPS + hash_counter + byte_counter + eof + num_bytes_read + chunk + bytes | ||
| // + length + has_n_bytes + chunk_bytes + preimage | ||
| pub const SCRATCH_SIZE: usize = 98; |
There was a problem hiding this comment.
the comment says you're adding two things, chunk_bytes + preimage, and yet the size only grows by one
There was a problem hiding this comment.
It's just the preimage key that is being added wrt what's in master. The problem is that in the old comment the chunk_bytes were not written down, but they were in any case part of the state https://github.com/o1-labs/proof-systems/blob/7d51847c00ff790bc22af3c83ddedc1deb070e38/o1vm/src/mips/column.rs#L26C1-L27C1
marcbeunardeau88
approved these changes
Sep 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2480 +/- ##
==========================================
+ Coverage 73.41% 73.42% +0.01%
==========================================
Files 234 234
Lines 54275 54275
==========================================
+ Hits 39846 39854 +8
+ Misses 14429 14421 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based upon #2278.
The only difference is that the above PR assumed that bytes corresponding to the length of the preimage were always read in a different instruction than actual preimage bytes. But I am no longer sure that I had checked that thoroughly back then, so I am creating this PR to solely include the fix for the hash digest format: that is, making sure that both in MIPS and Keccak the data sent to the communication channel corresponds to the 31 bytes of the preimage (no MSB in either of them). I left the check of the length bytes as a FIXME for the future.